Attachment 171124 Details for Bug 36598 – Bug 36598: Add comments asking to keep both CSRF checks in sync

[patch] Bug 36598: Add comments asking to keep both CSRF checks in sync

Bug-36598-Add-comments-asking-to-keep-both-CSRF-ch.patch (text/plain), 1.27 KB, created by Marcel de Rooy on 2024-09-06 07:40:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-09-06 07:40:33 UTC

Size: 1.27 KB

patch

obsolete

>From b6aa8b9cde9852c677e912ae33b9a09930f52396 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Tue, 14 May 2024 09:34:31 +0200
>Subject: [PATCH] Bug 36598: Add comments asking to keep both CSRF checks in
> sync
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/App/Plugin/CSRF.pm | 2 ++
> Koha/Middleware/CSRF.pm | 2 ++
> 2 files changed, 4 insertions(+)
>
>diff --git a/Koha/App/Plugin/CSRF.pm b/Koha/App/Plugin/CSRF.pm
>index 01ecb3897d..5e487fb097 100644
>--- a/Koha/App/Plugin/CSRF.pm
>+++ b/Koha/App/Plugin/CSRF.pm
>@@ -62,6 +62,8 @@ this case, no verification is done.
> 
> =cut
> 
>+# If you need to update the logic here, please also update Koha::Middleware::CSRF
>+
> sub register {
>     my ( $self, $app, $conf ) = @_;
> 
>diff --git a/Koha/Middleware/CSRF.pm b/Koha/Middleware/CSRF.pm
>index 29b1e1ae25..58e75c948e 100644
>--- a/Koha/Middleware/CSRF.pm
>+++ b/Koha/Middleware/CSRF.pm
>@@ -20,6 +20,8 @@ use Modern::Perl;
> use parent qw(Plack::Middleware);
> use Plack::Response;
> 
>+# If you need to update the logic here, please also update Koha::App::Plugin::CSRF
>+
> sub call {
>     my ( $self, $env ) = @_;
>     my $req = Plack::Request->new($env);
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36598: 164847 | 164848 | 164870 | 165075 | 165076 | 166094 | 166634 | 166673 | 166675 | 166727 | 166728 | 166729 | 166730 | 166731 | 166732 | 166733 | 171119 | 171120 | 171121 | 171122 | 171123 | 171124 | 171125