Attachment 171135 Details for Bug 37848 – Bug 37848: Fix "Run with template" dropdown menu style

[patch] Bug 37848: Fix "Run with template" dropdown menu style

Bug-37848-Fix-Run-with-template-dropdown-menu-styl.patch (text/plain), 2.42 KB, created by Caroline Cyr La Rose on 2024-09-06 13:03:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2024-09-06 13:03:56 UTC

Size: 2.42 KB

patch

obsolete

>From ee8ca3c3655bf3bb5cc895e727137f8a1fc47e4e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 6 Sep 2024 11:42:09 +0000
>Subject: [PATCH] Bug 37848: Fix "Run with template" dropdown menu style
>
>This patch adds the missing "dropdown-item" class to the "Run with
>template" dropdown menu markup in order to correct the menu's style.
>
>The patch also adds a template ID to the menu items' id attributes so
>that we don't have duplicate IDs.
>
>To test, apply the patch and go to Tools -> Notices.
>
>(testing steps copied from Bug 36157)
>
>1. Create a notice with the module of "Reports" -- add something to the
>   "Print" section. Example from the other bug:
>
>    [% FOREACH b IN data %]
>      <div class="panel panel-default">
>         <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
>         <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
>         <div class="panel-footer">ID: [% b.borrowernumber %]</div>
>      </div>
>    [% END %]
>
>2. Create and run a saved report. Example from bug 36157:
>
>    SELECT * FROM borrowers
>
>3. Click on the "Run with template" dropdown and confirm that it is
>   styled correctly.
>4. Click to run the report with the template and confirm that it works
>   correctly.
>
>Sponsored-by: Athens County Public Libraries
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index bdaafec285..24a564901c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -78,7 +78,7 @@
>                 <ul class="dropdown-menu">
>                     [% FOREACH tmpl IN templates %]
>                         <li>
>-                            <a id="runreport" href="/cgi-bin/koha/reports/guided_reports.pl?id=[% id | html %]&amp;op=run&amp;template=[% tmpl.id | html %][% PROCESS params %]">
>+                            <a class="dropdown-item" id="runreport_[% tmpl.id | html %]" href="/cgi-bin/koha/reports/guided_reports.pl?id=[% id | html %]&amp;op=run&amp;template=[% tmpl.id | html %][% PROCESS params %]">
>                                 [% tmpl.name | html %]
>                             </a>
>                         </li>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37848: 171097 | 171132 | 171135 | 172268