Bugzilla – Attachment 171136 Details for
Bug 23685
Exporting report may consume unlimited memory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23685: (follow-up) Control ODS exporting
Bug-23685-follow-up-Control-ODS-exporting.patch (text/plain), 3.14 KB, created by
Marcel de Rooy
on 2024-09-06 13:11:09 UTC
(
hide
)
Description:
Bug 23685: (follow-up) Control ODS exporting
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-09-06 13:11:09 UTC
Size:
3.14 KB
patch
obsolete
>From fee39ec80b122bb0d0121809e34c6711fcd44a1c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 6 Sep 2024 09:32:11 +0000 >Subject: [PATCH] Bug 23685: (follow-up) Control ODS exporting >Content-Type: text/plain; charset=utf-8 > >The pref ReportingAllowsODS_Export should be true for exporting >to ODS in Reporting. > >Test plan: >Set pref to false value. >Check if option is no longer available on report's Download menu. >Manipulate URL with op=export&format=ods. No data expected. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 4 +++- > reports/guided_reports.pl | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >index bdaafec285..6c93c0264e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >@@ -139,7 +139,9 @@ > <ul class="dropdown-menu"> > <li><a class="dropdown-item" id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?op=export&format=csv&id=[% id | html %]&reportname=[% name |uri %][% PROCESS params %]">[% PROCESS 'delimiter_text.inc' %]</a></li> > <li><a class="dropdown-item" id="tab" href="/cgi-bin/koha/reports/guided_reports.pl?op=export&format=tab&id=[% id | html %]&reportname=[% name |uri %][% PROCESS params %]">Tab separated text</a></li> >- <li><a class="dropdown-item" id="ods" href="/cgi-bin/koha/reports/guided_reports.pl?op=export&format=ods&id=[% id | html %]&reportname=[% name |uri %][% PROCESS params %]">Open Document Spreadsheet</a></li> >+ [% IF Koha.Preference('ReportingAllowsODS_Export') %] >+ <li><a class="dropdown-item" id="ods" href="/cgi-bin/koha/reports/guided_reports.pl?op=export&format=ods&id=[% id | html %]&reportname=[% name |uri %][% PROCESS params %]">Open Document Spreadsheet</a></li> >+ [% END %] > [% IF processed_notice_title %] > <li><a class="dropdown-item" id="template" href="/cgi-bin/koha/reports/guided_reports.pl?op=export&format=template&id=[% id | html %]&template=[% template_id | html %]&reportname=[% name |uri %][% PROCESS params %]">Rendered template ([% processed_notice_title | html %])</a></li> > [% END %] >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 7f1dc8a790..2d651551d1 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -657,7 +657,7 @@ elsif ($op eq 'export'){ > } > } > } >- elsif ( $format eq 'ods' ) { >+ elsif ( $format eq 'ods' && C4::Context->preference('ReportingAllowsODS_Export') ) { > $type = 'application/vnd.oasis.opendocument.spreadsheet'; > my $ods_fh = File::Temp->new( UNLINK => 0 ); > my $ods_filepath = $ods_fh->filename; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23685
:
168116
|
168570
|
168577
|
171136
|
171137
|
171138
|
171139
|
171140
|
171141
|
171142
|
171143
|
171144
|
171145
|
171171
|
171172
|
171173
|
171174
|
171175
|
171571
|
171572
|
171573
|
171574
|
171575