Attachment 171239 Details for Bug 37838 – Bug 37838: Fix broken remove button in course reserves

[patch] Bug 37838: Fix broken remove button in course reserves

Bug-37838-Fix-broken-remove-button-in-course-reser.patch (text/plain), 1.63 KB, created by Wainui Witika-Park on 2024-09-10 03:09:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Wainui Witika-Park

Created: 2024-09-10 03:09:47 UTC

Size: 1.63 KB

patch

obsolete

>From 1470b3e31188625a54671ec8d09bcc87e7237dc4 Mon Sep 17 00:00:00 2001
>From: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
>Date: Tue, 10 Sep 2024 03:06:15 +0000
>Subject: [PATCH] Bug 37838: Fix broken remove button in course reserves
>
>To test:
>1) Go to staff client -> Course reserves
>2) Create a course or go to an existing course
>3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
>4) Go to the second page of results on the course details page
>5) Click the Remove button next to a result
>6) Notice how the button just makes the page move to the top
>7) Apply patch
>8) Repeat steps 1-5
>9) Notice how the remove button is working as expected
>
>Sponsored-by: Toi Ohomai Institute of Technology
>---
> .../prog/en/modules/course_reserves/course-details.tt           | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>index 27cb90917cf..929db917c35 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>@@ -341,7 +341,7 @@
>                 "autoWidth": false,
>             }, table_settings );
> 
>-            $(".delete_item").on( 'click', function(e){
>+            $("#course_reserves_table").on( 'click', " .delete_item", function(e){
>                 e.preventDefault();
>                 if (confirmDelete(_("Are you sure you want to remove this item from the course?") )) {
>                     cr_id = $(this).data('cr-id');
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37838: 171044 | 171239 | 171354 | 171805