Attachment 171247 Details for Bug 37651 – Bug 37651: Add ConfirmFutureHolds to item->current_holds

[patch] Bug 37651: Add ConfirmFutureHolds to item->current_holds

Bug-37651-Add-ConfirmFutureHolds-to-item-currentho.patch (text/plain), 1.48 KB, created by Marcel de Rooy on 2024-09-10 12:20:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-09-10 12:20:40 UTC

Size: 1.48 KB

patch

obsolete

>From 96e16ac1d8d04b0682acdc949d323061399618da Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 15 Aug 2024 16:04:25 +0200
>Subject: [PATCH] Bug 37651: Add ConfirmFutureHolds to item->current_holds
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>Add future item level hold for another branch.
>Check in. Confirm and transfer.
>Note that without this patch, there is no patron info for the column
>On hold for on transferstoreceive.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Item.pm | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Item.pm b/Koha/Item.pm
>index 05d65d1da3..2744be4c1d 100644
>--- a/Koha/Item.pm
>+++ b/Koha/Item.pm
>@@ -1112,12 +1112,13 @@ sub article_request_type {
> sub current_holds {
>     my ( $self ) = @_;
>     my $attributes = { order_by => 'priority' };
>-    my $dtf = Koha::Database->new->schema->storage->datetime_parser;
>-    my $params = {
>+    my $dtf        = Koha::Database->new->schema->storage->datetime_parser;
>+    my $dt         = dt_from_string()->add( days => C4::Context->preference('ConfirmFutureHolds') || 0 );
>+    my $params     = {
>         itemnumber => $self->itemnumber,
>-        suspend => 0,
>-        -or => [
>-            reservedate => { '<=' => $dtf->format_date(dt_from_string) },
>+        suspend    => 0,
>+        -or        => [
>+            reservedate => { '<=' => $dtf->format_date($dt) },
>             waitingdate => { '!=' => undef },
>         ],
>     };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37651: 171247 | 171248 | 171249 | 171250