Attachment 171270 Details for Bug 37213 – Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs

[patch] Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs

Bug-37213-follow-up-Remove-stray-em-make-title-log.patch (text/plain), 2.57 KB, created by Paul Derscheid on 2024-09-10 16:38:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Derscheid

Created: 2024-09-10 16:38:43 UTC

Size: 2.57 KB

patch

obsolete

>From 83e87ca570eabef3cd93bebb670f1d4430dac1b4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 28 Jun 2024 11:21:13 +0000
>Subject: [PATCH] Bug 37213: (follow-up) Remove stray </em>, make title logic
> consistent with breadcrumbs
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
>---
> .../rotating_collections/editCollections.tt   | 20 +++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt
>index c2cbb3a43e..169ad43695 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt
>@@ -4,13 +4,21 @@
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% FILTER collapse %]
>-    [% IF ( op == "new" ) %]
>-        [% t("Add a new collection") | html %]
>+    [% IF ( op == "new" || op == "edit" ) %]
>+        [% IF ( previousActionEdit ) %]
>+            [% t("Edit collection") | html %] &rsaquo;
>+            [% tx("Collection '{collection_title}'", { collection_title = editColTitle }) | html %]
>+        [% ELSE %]
>+            [% t("Add a new collection") | html %]
>+        [% END %]
>     [% ELSIF ( op == "cud-delete" ) %]
>         [% t("Collection deleted") | html %]
>-    [% ELSE %]
>-        [% t("Edit collection") | html %] &rsaquo;
>-        [% tx("Collection '{collection_title}'", { collection_title = editColTitle }) | html %]
>+    [% ELSIF ( op == "cud-create" ) %]
>+        [% IF ( createSuccess ) %]
>+            [% t("Collection created successfully") | html %]
>+        [% ELSE %]
>+            [% t("Collection creation failed") | html %]
>+        [% END %]
>     [% END %] &rsaquo;
>     [% t("Rotating collections") | html %] &rsaquo;
>     [% t("Tools") | html %] &rsaquo;
>@@ -52,7 +60,7 @@
>             [% END %]
>         [% ELSE %]
>             [% WRAPPER breadcrumb_item %]
>-                <a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% editColId | uri %]">[% tx("Collection '{collection_title}'", { collection_title = editColTitle }) | html %]</em></a>
>+                <a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% editColId | uri %]">[% tx("Collection '{collection_title}'", { collection_title = editColTitle }) | html %]</a>
>             [% END %]
>             [% WRAPPER breadcrumb_item bc_active= 1 %]
>                 [% t("Edit collection") | html %]
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 37213: 168214 | 168216 | 168232 | 168575 | 168576 | 171269 | 171270