Bugzilla – Attachment 171274 Details for
Bug 14250
Don't allow to generate discharges for patrons with fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14250: (follow-up) Update messages
Bug-14250-follow-up-Update-messages.patch (text/plain), 5.51 KB, created by
Sukhmandeep
on 2024-09-10 16:50:13 UTC
(
hide
)
Description:
Bug 14250: (follow-up) Update messages
Filename:
MIME Type:
Creator:
Sukhmandeep
Created:
2024-09-10 16:50:13 UTC
Size:
5.51 KB
patch
obsolete
>From b1c1d6736ffe5259377265a6970c557614694cdb Mon Sep 17 00:00:00 2001 >From: David Nind <david@davidnind.com> >Date: Mon, 26 Aug 2024 11:18:43 +0000 >Subject: [PATCH] Bug 14250: (follow-up) Update messages > >Update the text for the reasons the patron cannot be discharged. > >Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> >--- > .../prog/en/modules/members/discharge.tt | 8 ++++---- > .../bootstrap/en/modules/opac-discharge.tt | 16 ++++++++-------- > 2 files changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt >index 4055737f31..7a63daa7a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt >@@ -53,19 +53,19 @@ > </div> > [% END %] > [% UNLESS can_be_discharged %] >- <p>Cannot edit discharge for following reasons: </p> >+ <p>A discharge cannot be generated for this patron because:</p> > <ul> > [% IF discharge_problems.checkouts %] >- <li>They have [% discharge_problems.checkouts | html %] item(s) checked out</li> >+ <li>The patron has [% discharge_problems.checkouts | html %] item(s) checked out</li> > [% END %] > > [% IF discharge_problems.debt %] >- <li>They have unpaid fines totaling [% discharge_problems.debt | $Price %]</li> >+ <li>The patron has unpaid charges of [% discharge_problems.debt | $Price %]</li> > [% END %] > </ul> > [% ELSE %] > [% IF patron.holds.count %] >- <p>Patron has holds. They will be cancelled if the discharge is generated.</p> >+ <p>The patron has holds. The holds will be cancelled if the discharge is generated.</p> > [% END %] > <div class="btn-toolbar"> > <form method="post"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >index cc97779c62..3a3f381218 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >@@ -45,16 +45,16 @@ > [% ELSIF pending %] > <p>Your discharge will be available on this page within a few days.</p> > [% ELSIF failure %] >- <p>You cannot be discharged, you have checked out items. Please return items before asking for a discharge.</p> >+ <p>You cannot be discharged because you have checked out items. Please return your checked out items before asking for a discharge.</p> > <ul> > [% IF has_debt %] >- <li> You have unpaid fines. Please pay your fines before reapplying.</li> >+ <li>You have unpaid charges. Please pay your charges before reapplying.</li> > [% END %] > [% IF has_issues %] >- <li> You have checked out items. Please return them before reapplying.</li> >+ <li>You have checked out items. Please return your checked out items before reapplying.</li> > [% END %] > [% IF !has_issue and !has_debt %] >- <li> Patron cannot be discharged for an unknown reason, please contact a librarian for more information</li> >+ <li>You cannot be discharged for an unknown reason. Please contact library staff for more information.</li> > [% END %] > </ul> > [% ELSIF not messages %] >@@ -62,19 +62,19 @@ > <p>This document certifies that you have returned all borrowed items. It is sometimes asked during a file transfer from a school to another. The discharge is sent by us to your school. You will also find it available on your reader account.</p> > <p><strong>Warning</strong>: This request is only valid if you are in good standing with the library. Once the application is made, you can not borrow library materials.</p> > [% UNLESS can_be_discharged %] >- <div class="alert alert-info">You cannot be discharged for following reasons: >+ <div class="alert alert-info">You cannot be discharged because: > <ul> > [% IF discharge_problems.checkouts %] > <li> > You have [% discharge_problems.checkouts | html %] item(s) checked out. >- Please return them before reapplying. >+ Please return your checked out items before reapplying. > </li> > [% END %] > > [% IF discharge_problems.debt %] > <li> >- They have unpaid fines totaling [% discharge_problems.debt | $Price %]. >- Please pay your fines before reapplying. >+ You have unpaid charges of [% discharge_problems.debt | $Price %]. >+ Please pay your charges before reapplying. > </li> > [% END %] > </ul> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14250
:
170136
|
170228
|
170581
|
170607
|
170662
|
170663
|
170664
|
170705
|
170706
|
170707
|
170708
|
171025
|
171026
|
171271
|
171272
|
171273
| 171274 |
171275
|
171276