Bugzilla – Attachment 171307 Details for
Bug 37870
UI/Form/Builder/Item.t and Biblio.t are still failing randomly (cn_source sort)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37870: Remove warning if biblionumber is not passed
Bug-37870-Remove-warning-if-biblionumber-is-not-pa.patch (text/plain), 1.22 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-09-11 13:12:38 UTC
(
hide
)
Description:
Bug 37870: Remove warning if biblionumber is not passed
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-09-11 13:12:38 UTC
Size:
1.22 KB
patch
obsolete
>From e9b06e7866514174b90bd15fd493b040b17a23d1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 10 Sep 2024 09:57:30 +0200 >Subject: [PATCH] Bug 37870: Remove warning if biblionumber is not passed > >Not directly related to the failure, only a bit of cleaning before >starting. > >Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/UI/Form/Builder/Biblio.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/Koha/UI/Form/Builder/Biblio.pm b/Koha/UI/Form/Builder/Biblio.pm >index c17d4965e4f..b0603dedde3 100644 >--- a/Koha/UI/Form/Builder/Biblio.pm >+++ b/Koha/UI/Form/Builder/Biblio.pm >@@ -50,8 +50,11 @@ sub new { > > my $self = {}; > >- $self->{biblionumber} = $params->{biblionumber} =~ s/\D//gr; >- # just in case biblionumber obtained from CGI and passed directly here contains weird characters like spaces >+ if ( exists $self->{biblionumber} ) { >+ $self->{biblionumber} = $params->{biblionumber} =~ s/\D//gr; >+ >+ # just in case biblionumber obtained from CGI and passed directly here contains weird characters like spaces >+ } > > bless $self, $class; > return $self; >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37870
:
171242
|
171243
|
171244
|
171283
|
171284
|
171285
| 171307 |
171308
|
171309
|
171310