Attachment 171325 Details for Bug 37827 – Bug 37827: Switch OPAC download list form from POST to GET

[patch] Bug 37827: Switch OPAC download list form from POST to GET

Bug-37827-Switch-OPAC-download-list-form-from-POST.patch (text/plain), 1.92 KB, created by Jonathan Druart on 2024-09-11 13:51:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-09-11 13:51:43 UTC

Size: 1.92 KB

patch

obsolete

>From eb8db1af02d5d3df0604016daf09502c355c745e Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Tue, 3 Sep 2024 21:46:11 -0700
>Subject: [PATCH] Bug 37827: Switch OPAC download list form from POST to GET
>
>The hidden form that the OPAC uses for downloading a list has no need to be
>a POST, which is good because it can't be one without having an op param
>that starts with "cud-" which it doesn't have.
>
>Test plan:
>1. Nothing visible will change, so start with the patch applied
>2. Log in to the OPAC, then do a search for something like Perl which will
>   return a couple of results. Select two, With selected titles: Add to
>   list - New list - give it a name and Save
>3. Lists - choose the one you just created
>4. Download - ISBD
>5. Verify that the page you were on didn't change, that a file was downloaded,
>   and that the file contains the two titles in your list
>
>Sponsored-by: Chetco Community Public Library
>Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 65457d5350f..9c85e423c8a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -805,8 +805,7 @@
>     </div> 
> </div> 
> 
>-<form method="post" id="download_list" action="/cgi-bin/koha/opac-downloadshelf.pl">
>-    [% INCLUDE 'csrf-token.inc' %]
>+<form method="get" id="download_list" action="/cgi-bin/koha/opac-downloadshelf.pl">
>     <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber | html %]" />
>     <input type="hidden" name="format" id="download_format" value="" />
> </form>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37827: 171008 | 171016 | 171325