Bugzilla – Attachment 171365 Details for
Bug 36197
Allow for OPAC unauthenticated ILL request
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36197: Only check limits for regular requests
Bug-36197-Only-check-limits-for-regular-requests.patch (text/plain), 1.36 KB, created by
Pedro Amorim
on 2024-09-12 09:34:57 UTC
(
hide
)
Description:
Bug 36197: Only check limits for regular requests
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-09-12 09:34:57 UTC
Size:
1.36 KB
patch
obsolete
>From 9ba717af27b1f2dec96b1e9df497bc14be645082 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 5 Mar 2024 17:07:01 +0000 >Subject: [PATCH] Bug 36197: Only check limits for regular requests > >Skip for unauthenticated requests > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/ILL/Request.pm | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 4df167d15f..063c3a0f10 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1027,18 +1027,14 @@ sub backend_create { > # ... complex case: commit! > > # Do we still have space for an ILL or should we queue? >- my $permitted = $self->check_limits( >- { patron => $self->patron }, { librarycode => $self->branchcode } >- ); >- >- # Now augment our committed request. >- >- $result->{permitted} = $permitted; # Queue request? >- >- # This involves... >- >- # ...Updating status! >- $self->status('QUEUED')->store unless ( $permitted ); >+ my $permitted = 1; >+ if( $self->patron ) { >+ $permitted = $self->check_limits( >+ { patron => $self->patron }, { librarycode => $self->branchcode } >+ ); >+ $result->{permitted} = $permitted; >+ $self->status('QUEUED')->store unless ($permitted); >+ } > > ## Handle Unmediated ILLs > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36197
:
171358
|
171359
|
171360
|
171361
|
171362
|
171363
|
171364
|
171365
|
171366
|
171367
|
171368
|
171369
|
171370
|
171371
|
174495
|
174496
|
174497
|
174498
|
174499
|
174500
|
174501
|
174502
|
174503
|
174504
|
174505
|
174506
|
174507
|
174508
|
176564
|
176565
|
176680
|
176723
|
176724
|
176726
|
176727