Bugzilla – Attachment 171452 Details for
Bug 37797
Choosing not to delete a budget does not need to be a form submission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37797: Change cancel button to a link styled as a button
Bug-37797-Change-cancel-button-to-a-link-styled-as.patch (text/plain), 1.96 KB, created by
Martin Renvoize (ashimema)
on 2024-09-13 12:01:55 UTC
(
hide
)
Description:
Bug 37797: Change cancel button to a link styled as a button
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-09-13 12:01:55 UTC
Size:
1.96 KB
patch
obsolete
>From 1087a88fc65a50a5a24ce38709925cff469ee35b Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 30 Aug 2024 16:50:36 -0400 >Subject: [PATCH] Bug 37797: Change cancel button to a link styled as a button > >On the confirmation page for deleting a budget, change "Do not delete" >from a form submission to a link (styled to look like a button) in order >to avoid errors from POSTing with no op. > >To test: >1. Go to Acquisitions > Budgets >2. Create a test budget >3. Attempt to delete the test budget >4. On the confirmation page, click "No, don't delete" >--> An error appears saying that the form was POSTed with no op! >5. Apply patch >6. Repeat steps 3-4 >--> You are linked back to the Budgets page. The budget was not deleted. > >Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt >index 375787a3f4f..210b1043d34 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt >@@ -324,10 +324,7 @@ > <input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" /> > <button type="submit" class="btn btn-default approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button> > </form> >- <form action="[% script_name | html %]" method="post"> >- [% INCLUDE 'csrf-token.inc' %] >- <button type="submit" class="btn btn-default deny"><i class="fa fa-fw fa-times"></i> No, do not delete</button> >- </form> >+ <a href="/cgi-bin/koha/admin/aqbudgetperiods.pl" class="btn btn-default deny"><i class="fa fa-fw fa-times"></i> No, do not delete</a> > [% END %] > > </div> >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37797
:
170928
|
170977
| 171452