Attachment 171460 Details for Bug 36595 – Bug 36595: (follow-up) Conditionals and consistency

[patch] Bug 36595: (follow-up) Conditionals and consistency

Bug-36595-follow-up-Conditionals-and-consistency.patch (text/plain), 1.89 KB, created by Martin Renvoize (ashimema) on 2024-09-13 13:41:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-09-13 13:41:23 UTC

Size: 1.89 KB

patch

obsolete

>From 03849a5d3675dac009cec449d12c2e6347aba5ab Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 13 Sep 2024 14:39:32 +0100
>Subject: [PATCH] Bug 36595: (follow-up) Conditionals and consistency
>
>Added a conditional to only display email if there's actualy a
>notice_email_address present.
>
>Updated the address used to match the address displayed.
>
>Not sure how to resolve the translation issue.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index 890085ad05a..0bf9ebb22a5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -218,10 +218,12 @@
> 
> [% UNLESS Koha.Preference('HidePatronName') %]
> [% itemsloo.patron.phone | html %]
>+ [% IF itemsloo.patron.notice_email_address %]
> 
>- <a href="mailto:[% itemsloo.patron.email | uri %]?subject=Hold item: [% itemsloo.title | uri %]">
>+ <a href="mailto:[% itemsloo.patron.notice_email_address | uri %]?subject=Hold item: [% itemsloo.title | uri %]">
> [% itemsloo.patron.notice_email_address | html %]</a>
> 
>+ [% END %]
> [% END %]
> </td>
> <td class="hq-patroncategory">[% itemsloo.patron.category.description | html %] ([% itemsloo.patron.categorycode | html %])</td>
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 36595: 164841 | 164851 | 164854 | 166626 | 169518 | 169701 | 169738 | 171460