Bugzilla – Attachment 171495 Details for
Bug 37832
Rental discount is should be decimal like other similar fields in circulation rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37832: Fix Rentaldiscount to be decimal like other similar fields
Bug-37832-Fix-Rentaldiscount-to-be-decimal-like-ot.patch (text/plain), 1.85 KB, created by
Olivier Vezina
on 2024-09-13 19:05:16 UTC
(
hide
)
Description:
Bug 37832: Fix Rentaldiscount to be decimal like other similar fields
Filename:
MIME Type:
Creator:
Olivier Vezina
Created:
2024-09-13 19:05:16 UTC
Size:
1.85 KB
patch
obsolete
>From e728e7c271ff8a10a9c10bec9ca1f45746777cfd Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Wed, 4 Sep 2024 16:45:57 +0300 >Subject: [PATCH] Bug 37832: Fix Rentaldiscount to be decimal like other > similar fields > >Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. > >1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. >2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. > >Signed-off-by: Olivier V <olivier.vezina@inLibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 370bd7b17a..bc92f40168 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -538,7 +538,7 @@ > </select> > </td> > [% END %] >- <td><input type="text" name="rentaldiscount" id="rentaldiscount" size="2" /></td> >+ <td><input type="text" name="rentaldiscount" id="rentaldiscount" size="3" inputmode="decimal" pattern="^\d+(\.\d{2})?$" /></td> > [% IF Koha.Preference('UseRecalls') %] > <td><input type="text" name="recalls_allowed" id="recalls_allowed" size="3"></td> > <td><input type="text" name="recalls_per_record" id="recalls_per_record" size="3"></td> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37832
:
171028
|
171495
|
176240