Bugzilla – Attachment 171496 Details for
Bug 37757
notice_email_address explodes if EmailFieldPrimary is not valid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37757: (follow-up) Adjust existing tests
Bug-37757-follow-up-Adjust-existing-tests.patch (text/plain), 2.67 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-09-13 19:15:55 UTC
(
hide
)
Description:
Bug 37757: (follow-up) Adjust existing tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-09-13 19:15:55 UTC
Size:
2.67 KB
patch
obsolete
>From 20f893920b51e76a214b8d5b1b1194bea178d420 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 13 Sep 2024 16:14:54 -0300 >Subject: [PATCH] Bug 37757: (follow-up) Adjust existing tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Auth_with_shibboleth.t | 2 +- > t/db_dependent/Letters.t | 2 +- > t/db_dependent/Letters/TemplateToolkit.t | 2 ++ > t/db_dependent/Message.t | 2 +- > 4 files changed, 5 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Auth_with_shibboleth.t b/t/db_dependent/Auth_with_shibboleth.t >index c42dd9d602f..440eef2a1f6 100755 >--- a/t/db_dependent/Auth_with_shibboleth.t >+++ b/t/db_dependent/Auth_with_shibboleth.t >@@ -46,7 +46,7 @@ my $interface = 'opac'; > # Mock few preferences > t::lib::Mocks::mock_preference('OPACBaseURL', 'testopac.com' ); > t::lib::Mocks::mock_preference('StaffClientBaseURL', 'teststaff.com' ); >-t::lib::Mocks::mock_preference( 'EmailFieldPrimary', 'OFF' ); >+t::lib::Mocks::mock_preference( 'EmailFieldPrimary', '' ); > t::lib::Mocks::mock_preference( 'EmailFieldPrecedence', 'emailpro' ); > > # Mock Context: config, tz and interface >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index d607fa7d04a..fbe496d7ac6 100755 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -74,7 +74,7 @@ my $dbh = C4::Context->dbh; > $dbh->do(q|DELETE FROM letter|); > $dbh->do(q|DELETE FROM message_queue|); > $dbh->do(q|DELETE FROM message_transport_types|); >-t::lib::Mocks::mock_preference( 'EmailFieldPrimary', 'OFF' ); >+t::lib::Mocks::mock_preference( 'EmailFieldPrimary', '' ); > > my $library = $builder->build({ > source => 'Branch', >diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t >index 1c6fea8ee0a..1ac70733b14 100755 >--- a/t/db_dependent/Letters/TemplateToolkit.t >+++ b/t/db_dependent/Letters/TemplateToolkit.t >@@ -49,6 +49,8 @@ use Koha::Notice::Messages; > use Koha::Notice::Templates; > use Koha::Patron::Modification; > >+t::lib::Mocks::mock_preference( 'EmailFieldPrimary', '' ); >+ > my $schema = Koha::Database->schema; > $schema->storage->txn_begin(); > >diff --git a/t/db_dependent/Message.t b/t/db_dependent/Message.t >index 95673c36c9e..c100dd5450a 100755 >--- a/t/db_dependent/Message.t >+++ b/t/db_dependent/Message.t >@@ -50,7 +50,7 @@ my $letter = C4::Letters::GetPreparedLetter( > ); > > >-t::lib::Mocks::mock_preference( 'EmailFieldPrimary', 'OFF' ); >+t::lib::Mocks::mock_preference( 'EmailFieldPrimary', '' ); > C4::Message->enqueue($letter, $patron, 'email'); > my $message = C4::Message->find_last_message($patron->unblessed, 'TEST_MESSAGE', 'email'); > like( $message->{metadata}, qr{heÃllo} ); >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37757
:
170840
|
170841
|
170842
|
170843
|
171160
|
171161
|
171162
|
171163
|
171447
|
171448
|
171449
|
171450
| 171496