Attachment 171579 Details for Bug 26282 – Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked

[patch] Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked

Bug-26282-QA-follow-up-Always-notify-patron-if-not.patch (text/plain), 1.08 KB, created by Kyle M Hall (khall) on 2024-09-16 18:09:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-09-16 18:09:35 UTC

Size: 1.08 KB

patch

obsolete

>From 8d8b9de307f9927b5156bbc3b331a702a2b50569 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 25 Nov 2020 10:09:18 -0500
>Subject: [PATCH] Bug 26282: (QA follow-up) Always notify patron if notify
> checkbox is checked
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> Koha/Hold.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index f2898c8fd18..ca691c4ed9e 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -738,7 +738,7 @@ sub cancel {
>                 }, undef, $self->id
>             );
> 
>-            if ( $params->{cancellation_reason} && $params->{notify_patron} ) {
>+            if ( $params->{notify_patron} ) {
>                 my $letter = C4::Letters::GetPreparedLetter(
>                     module                 => 'reserves',
>                     letter_code            => 'HOLD_CANCELLATION',
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 26282: 109286 | 113960 | 113991 | 114007 | 114008 | 114009 | 114010 | 114011 | 114012 | 114013 | 114014 | 114015 | 114016 | 114028 | 114030 | 114031 | 114032 | 114033 | 114034 | 114035 | 114247 | 114248 | 114249 | 114250 | 114251 | 114252 | 114253 | 114254 | 114255 | 114259 | 115193 | 115194 | 115195 | 115196 | 115197 | 115198 | 115199 | 115200 | 115201 | 122448 | 122449 | 122450 | 122451 | 122452 | 122453 | 122454 | 122455 | 122456 | 122550 | 138407 | 138408 | 138409 | 138410 | 138411 | 138412 | 138413 | 138414 | 138415 | 138416 | 138417 | 138418 | 138419 | 138469 | 141210 | 171577 | 171578 | 171579 | 171580 | 171581 | 171582 | 171583 | 171584 | 171585 | 171586 | 171587 | 171588 | 171589 | 171590 | 171592 | 171593