Attachment 171583 Details for Bug 26282 – Bug 26282: (QA follow-up) Update test

[patch] Bug 26282: (QA follow-up) Update test

Bug-26282-QA-follow-up-Update-test.patch (text/plain), 1.22 KB, created by Kyle M Hall (khall) on 2024-09-16 18:09:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-09-16 18:09:47 UTC

Size: 1.22 KB

patch

obsolete

>From e28d39b7bccc44f0d890f3e3828b6d830e2230e8 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Fri, 27 Nov 2020 09:04:05 +0000
>Subject: [PATCH] Bug 26282: (QA follow-up) Update test
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> t/db_dependent/Koha/Hold.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Hold.t b/t/db_dependent/Koha/Hold.t
>index 4b86529137f..04cacbffe75 100755
>--- a/t/db_dependent/Koha/Hold.t
>+++ b/t/db_dependent/Koha/Hold.t
>@@ -1172,7 +1172,7 @@ subtest 'cancel() tests' => sub {
> 
>     $get_prepared_letter_called = 0;
>     $hold->cancel({ notify_patron => 1 });
>-    ok( $get_prepared_letter_called, 'GetPreparedLetter called if notify_patron passed' );
>+    is( $get_prepared_letter_called, 0, 'GetPreparedLetter not called if notify_patron passed and no cancellation_reason passed' );
> 
>     isnt( $hold->cancellationdate, undef, 'cancellationdate gets set to the passed value' );
>     is( $hold->priority, 0, 'priority gets set to 0' );
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 26282: 109286 | 113960 | 113991 | 114007 | 114008 | 114009 | 114010 | 114011 | 114012 | 114013 | 114014 | 114015 | 114016 | 114028 | 114030 | 114031 | 114032 | 114033 | 114034 | 114035 | 114247 | 114248 | 114249 | 114250 | 114251 | 114252 | 114253 | 114254 | 114255 | 114259 | 115193 | 115194 | 115195 | 115196 | 115197 | 115198 | 115199 | 115200 | 115201 | 122448 | 122449 | 122450 | 122451 | 122452 | 122453 | 122454 | 122455 | 122456 | 122550 | 138407 | 138408 | 138409 | 138410 | 138411 | 138412 | 138413 | 138414 | 138415 | 138416 | 138417 | 138418 | 138419 | 138469 | 141210 | 171577 | 171578 | 171579 | 171580 | 171581 | 171582 | 171583 | 171584 | 171585 | 171586 | 171587 | 171588 | 171589 | 171590 | 171592 | 171593