Bugzilla – Attachment 171586 Details for
Bug 26282
Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26282: Update Holds to pull
Bug-26282-Update-Holds-to-pull.patch (text/plain), 3.12 KB, created by
Kyle M Hall (khall)
on 2024-09-16 18:09:56 UTC
(
hide
)
Description:
Bug 26282: Update Holds to pull
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-09-16 18:09:56 UTC
Size:
3.12 KB
patch
obsolete
>From 06af34ec9f41ec6e6b8e7cca51af4dd448818d9f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 2 Jul 2021 11:07:46 -0400 >Subject: [PATCH] Bug 26282: Update Holds to pull > >Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > circ/pendingreserves.pl | 21 ++++++++++++------- > .../prog/en/modules/circ/pendingreserves.tt | 10 +++++++-- > 2 files changed, 22 insertions(+), 9 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index c306bf6b8cc..c3fdc404274 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -300,14 +300,21 @@ foreach my $bibnum ( @biblionumbers ){ > push @holds_info, $hold_info; > } > >+my $cancel_notify_templates = Koha::Notice::Templates->search({ module => 'reserves', code => 'HOLD_CANCELLATION' }); >+my $cancel_notice_branches; >+while ( my $notice = $cancel_notify_templates->next ) { >+ $cancel_notice_branches->{$notice->branchcode} = 1; >+} >+ > $template->param( >- todaysdate => $today, >- from => $startdate, >- to => $enddate, >- holds_info => \@holds_info, >- HoldsToPullStartDate => C4::Context->preference('HoldsToPullStartDate') || PULL_INTERVAL, >- HoldsToPullEndDate => C4::Context->preference('ConfirmFutureHolds') || 0, >- messages => \@messages, >+ cancel_notice_branches => $cancel_notice_branches, >+ todaysdate => $today, >+ from => $startdate, >+ to => $enddate, >+ holds_info => \@holds_info, >+ HoldsToPullStartDate => C4::Context->preference('HoldsToPullStartDate') || PULL_INTERVAL, >+ messages => \@messages, >+ HoldsToPullEndDate => C4::Context->preference('ConfirmFutureHolds') || 0, > ); > > output_html_with_http_headers $input, $cookie, $template->output; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 3f4d741fabb..aff4c8be87c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -221,8 +221,14 @@ > [% END %] > </select> > >- <input type="checkbox" name="cancellation-notify-patron" id="cancellation-notify-patron" value="1" checked/> >- <label for="cancellation-notify-patron">Notify patron</label> >+ [% IF cancel_notice_branches.size %] >+ [% SET bc = hold.patron.branchcode %] >+ [% SET all_bc = "" %] >+ [% IF cancel_notice_branches.$bc || cancel_notice_branches.$all_bc %] >+ <input type="checkbox" name="cancellation-notify-patron" id="cancellation-notify-patron" value="1" checked/> >+ <label for="cancellation-notify-patron">Notify patron</label> >+ [% END %] >+ [% END %] > </div> > [% END %] > >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26282
:
109286
|
113960
|
113991
|
114007
|
114008
|
114009
|
114010
|
114011
|
114012
|
114013
|
114014
|
114015
|
114016
|
114028
|
114030
|
114031
|
114032
|
114033
|
114034
|
114035
|
114247
|
114248
|
114249
|
114250
|
114251
|
114252
|
114253
|
114254
|
114255
|
114259
|
115193
|
115194
|
115195
|
115196
|
115197
|
115198
|
115199
|
115200
|
115201
|
122448
|
122449
|
122450
|
122451
|
122452
|
122453
|
122454
|
122455
|
122456
|
122550
|
138407
|
138408
|
138409
|
138410
|
138411
|
138412
|
138413
|
138414
|
138415
|
138416
|
138417
|
138418
|
138419
|
138469
|
141210
|
171577
|
171578
|
171579
|
171580
|
171581
|
171582
|
171583
|
171584
|
171585
|
171586
|
171587
|
171588
|
171589
|
171590
|
171592
|
171593