Bugzilla – Attachment 171587 Details for
Bug 26282
Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26282: (QA follow-up) Remove invalid test
Bug-26282-QA-follow-up-Remove-invalid-test.patch (text/plain), 1.23 KB, created by
Kyle M Hall (khall)
on 2024-09-16 18:09:59 UTC
(
hide
)
Description:
Bug 26282: (QA follow-up) Remove invalid test
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-09-16 18:09:59 UTC
Size:
1.23 KB
patch
obsolete
>From 8ca2d67b6be06db549ed3b7f5d3db3454eb9a96c Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Mon, 1 Aug 2022 09:20:03 -0400 >Subject: [PATCH] Bug 26282: (QA follow-up) Remove invalid test > >A cancellation reason is not required, making this test invalid. >--- > t/db_dependent/Koha/Hold.t | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Hold.t b/t/db_dependent/Koha/Hold.t >index 04cacbffe75..44988e9ff85 100755 >--- a/t/db_dependent/Koha/Hold.t >+++ b/t/db_dependent/Koha/Hold.t >@@ -1092,7 +1092,7 @@ subtest 'change_type() tests' => sub { > > subtest 'cancel() tests' => sub { > >- plan tests => 12; >+ plan tests => 11; > > $schema->storage->txn_begin; > >@@ -1172,8 +1172,6 @@ subtest 'cancel() tests' => sub { > > $get_prepared_letter_called = 0; > $hold->cancel({ notify_patron => 1 }); >- is( $get_prepared_letter_called, 0, 'GetPreparedLetter not called if notify_patron passed and no cancellation_reason passed' ); >- > isnt( $hold->cancellationdate, undef, 'cancellationdate gets set to the passed value' ); > is( $hold->priority, 0, 'priority gets set to 0' ); > is( $hold->cancellation_reason, undef, 'cancellation_reason not passed' ); >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26282
:
109286
|
113960
|
113991
|
114007
|
114008
|
114009
|
114010
|
114011
|
114012
|
114013
|
114014
|
114015
|
114016
|
114028
|
114030
|
114031
|
114032
|
114033
|
114034
|
114035
|
114247
|
114248
|
114249
|
114250
|
114251
|
114252
|
114253
|
114254
|
114255
|
114259
|
115193
|
115194
|
115195
|
115196
|
115197
|
115198
|
115199
|
115200
|
115201
|
122448
|
122449
|
122450
|
122451
|
122452
|
122453
|
122454
|
122455
|
122456
|
122550
|
138407
|
138408
|
138409
|
138410
|
138411
|
138412
|
138413
|
138414
|
138415
|
138416
|
138417
|
138418
|
138419
|
138469
|
141210
|
171577
|
171578
|
171579
|
171580
|
171581
|
171582
|
171583
|
171584
|
171585
|
171586
|
171587
|
171588
|
171589
|
171590
|
171592
|
171593