Attachment 171600 Details for Bug 37928 – Bug 37928: Add missing dropdown-item class to "Upload image"

[patch] Bug 37928: Add missing dropdown-item class to "Upload image"

Bug-37928-Add-missing-dropdown-item-class-to-Uploa.patch (text/plain), 2.11 KB, created by Phil Ringnalda on 2024-09-17 01:52:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2024-09-17 01:52:22 UTC

Size: 2.11 KB

patch

obsolete

>From b3db9007e405796fbfedf10f1179c77265bd361b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 16 Sep 2024 12:26:49 +0200
>Subject: [PATCH] Bug 37928: Add missing dropdown-item class to "Upload image"
>
>"Upload image" item not correctly styled
>
>Test plan:
>Go to the bib detail page with at least one item.
>Open the action dropdown list and notice the "Upload image" is correctly
>styled with this patch
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 4a3d347a5b..e05cd016da 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -749,7 +749,7 @@
>                             nodes += '<div class="btn-group">';
>                             nodes += ' <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=%s&itemnumber=%s#edititem"><i class="fa-solid fa-pencil"></i> %s</a><a class="btn btn-default btn-xs dropdown-toggle" data-bs-toggle="dropdown"><span class="caret"></span></a>'.format(row.biblio_id, row.item_id, _("Edit"));
>                             nodes += ' <ul class="dropdown-menu pull-right">';
>-                            nodes += '  <li><a href="/cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=%s&amp;filetype=image"><i class="fa fa-upload"></i> %s</a></li>'.format(row.item_id, _("Upload image"));
>+                            nodes += '  <li><a class="dropdown-item" href="/cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=%s&amp;filetype=image"><i class="fa fa-upload"></i> %s</a></li>'.format(row.item_id, _("Upload image"));
>                             nodes += ' </ul>';
>                             nodes += '</div>';
>                         [% ELSE %]
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 37928: 171525 | 171600 | 171903