Bugzilla – Attachment 171629 Details for
Bug 37895
Update skeleton.pl to show an example use of coding guideline SQL14
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37895: (QA follow-up) Switch try/finally block to try/catch block
Bug-37895-QA-follow-up-Switch-tryfinally-block-to-.patch (text/plain), 1.18 KB, created by
Kyle M Hall (khall)
on 2024-09-17 14:39:53 UTC
(
hide
)
Description:
Bug 37895: (QA follow-up) Switch try/finally block to try/catch block
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-09-17 14:39:53 UTC
Size:
1.18 KB
patch
obsolete
>From cde39abc8d8e9ddfa885cf801224c76a1c837f63 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 17 Sep 2024 10:37:36 -0400 >Subject: [PATCH] Bug 37895: (QA follow-up) Switch try/finally block to > try/catch block > >--- > installer/data/mysql/atomicupdate/skeleton.pl | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/skeleton.pl b/installer/data/mysql/atomicupdate/skeleton.pl >index 62870ef5ecb..00e807744a1 100755 >--- a/installer/data/mysql/atomicupdate/skeleton.pl >+++ b/installer/data/mysql/atomicupdate/skeleton.pl >@@ -11,12 +11,9 @@ return { > # Do you stuffs here > try { > $dbh->do(q{}); >- } finally { >- if (@_) { >- say_failure( $out, "Database modification failed with errors: @_" ); >- } else { >- say_success( $out, "Database modification was successful!" ); >- } >+ say_success( $out, "Database modification was successful!" ); >+ } catch { >+ say_failure( $out, "Database modification failed with errors: $_" ); > }; > > # Print useful stuff here >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37895
:
171338
|
171383
| 171629 |
171660