Bugzilla – Attachment 171695 Details for
Bug 37812
Adjust Vue modals for Bootstrap 5
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37812: Prevent initialisation failure by using modal methods, not plain show, hide
Bug-37812-Prevent-initialisation-failure-by-using-.patch (text/plain), 2.45 KB, created by
David Nind
on 2024-09-18 21:07:27 UTC
(
hide
)
Description:
Bug 37812: Prevent initialisation failure by using modal methods, not plain show, hide
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-09-18 21:07:27 UTC
Size:
2.45 KB
patch
obsolete
>From f6a4ed6f869412512b47f9ed085f4f081dc313a4 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Tue, 17 Sep 2024 18:02:51 +0000 >Subject: [PATCH] Bug 37812: Prevent initialisation failure by using modal > methods, not plain show, hide > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../js/vue/components/Preservation/TrainsShow.vue | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue >index 407c560dd5..9b3496b09d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue >@@ -16,7 +16,7 @@ > <button > type="button" > class="btn-close" >- @click="closeModal" >+ data-bs-dismiss="modal" > aria-label="Close" > ></button> > </div> >@@ -60,7 +60,7 @@ > <button > class="btn btn-default deny cancel" > type="button" >- @click="closeModal" >+ data-bs-dismiss="modal" > > > <i class="fa fa-times"></i> Cancel > </button> >@@ -522,7 +522,7 @@ export default { > ) > }, > selectTrainForCopy(train_item_id) { >- $("#copy_item_to_train").show() >+ $("#copy_item_to_train").modal("show") > this.train_item_id_to_copy = train_item_id > }, > copyItem(event) { >@@ -537,7 +537,7 @@ export default { > .then( > success => { > this.setMessage(this.$__("Item copied successfully.")) >- this.closeModal() >+ $("#copy_item_to_train").modal("hide") > }, > error => { > this.setWarning( >@@ -548,9 +548,6 @@ export default { > } > ) > }, >- closeModal() { >- $("#copy_item_to_train").hide() >- }, > clearAll() { > this.selected_items = [] > if (this.item_table.display) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37812
:
170956
|
171252
|
171253
|
171604
|
171605
|
171625
|
171641
|
171651
|
171690
|
171691
|
171692
|
171693
|
171694
|
171695
|
171696
|
171697
|
171702
|
171703
|
171704
|
171705
|
171706
|
171707
|
171708
|
171758
|
171780
|
171781
|
171786