Attachment 171715 Details for Bug 37328 – Bug 37328: Cannot delete report after using Update and Run SQL button

[patch] Bug 37328: Cannot delete report after using Update and Run SQL button

0001-Bug-37328-Cannot-delete-report-after-using-Update-an.patch (text/plain), 2.20 KB, created by Emmi Takkinen on 2024-09-19 11:58:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2024-09-19 11:58:32 UTC

Size: 2.20 KB

patch

obsolete

>From f369674db208a65caccf4920041a5ab5845aa9a7 Mon Sep 17 00:00:00 2001
>From: CJ Lynce <cj.lynce@westlakelibrary.org>
>Date: Thu, 29 Aug 2024 15:07:05 +0000
>Subject: [PATCH] Bug 37328: Cannot delete report after using Update and Run
> SQL button
>
>Fixes the ability to delete a report from the report toolbar menu after running
>	the report, including displaying the delete confirm modal.
>
>To test:
>1) Login to staff client
>2) Navigate to Reports -> Create from SQL
>3) Create a short report (SELECT * FROM items), name it and SAVE it.
>4) On the resulting "Edit SQL report' page, click 'Update and run SQL'
>5) On the toolbar, click Edit -> Delete
>	Nothing happens
>6) Apply patch
>7) Return to Reports -> Saved Reports and Edit the report you created.
>8) On "Edit SQL report' page, click 'Update and run SQL'
>9) On the toolbar, click Edit -> Delete
>10) Confirm the delete modal.
>	The report is now deleted.
>
>Sponsored-by: Westlake Porter Public Library
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index bdaafec285..a1d30aee0b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -52,8 +52,8 @@
>                                     [% INCLUDE 'csrf-token.inc' %]
>                                     <input type="hidden" name="op" value="cud-delete" />
>                                     <input type="hidden" name="id" value="[% id | html %]" />
>+                                    <a class="dropdown-item submit-form-link" href="#" data-id="[% id | html %]" data-action="guided_reports.pl" data-method="post" data-op="cud-delete" data-confirmation-msg="Are you sure you want to delete this report?">Delete</a>
>                                 </form>
>-                                <a href="#" class="dropdown-item delete">Delete</a>
>                             </li>
>                         [% END %]
>                     </ul>
>-- 
>2.34.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 37328: 170872 | 170874 | 171167 | 171715 | 171838