Attachment 171736 Details for Bug 10190 – Bug 10190: Let the circulation_rules endpoint accept query parameters

[patch] Bug 10190: Let the circulation_rules endpoint accept query parameters

Bug-10190-Let-the-circulationrules-endpoint-accept.patch (text/plain), 1.87 KB, created by Martin Renvoize (ashimema) on 2024-09-19 13:20:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-09-19 13:20:46 UTC

Size: 1.87 KB

patch

obsolete

>From 6d7c6f71fd0d880e6dfb39de7ae20da310583eba Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 13 Aug 2024 14:18:49 +0000
>Subject: [PATCH] Bug 10190: Let the circulation_rules endpoint accept query
> parameters
>
>Sponsored-by: Glasgow Colleges Library Group
>---
> api/v1/swagger/paths/circulation_rules.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
>diff --git a/api/v1/swagger/paths/circulation_rules.yaml b/api/v1/swagger/paths/circulation_rules.yaml
>index 4b7e5e1cd65..cc4b6ac7c5c 100644
>--- a/api/v1/swagger/paths/circulation_rules.yaml
>+++ b/api/v1/swagger/paths/circulation_rules.yaml
>@@ -9,6 +9,13 @@
>     produces:
>       - application/json
>     parameters:
>+      - $ref: "../swagger.yaml#/parameters/match"
>+      - $ref: "../swagger.yaml#/parameters/order_by"
>+      - $ref: "../swagger.yaml#/parameters/page"
>+      - $ref: "../swagger.yaml#/parameters/per_page"
>+      - $ref: "../swagger.yaml#/parameters/q_param"
>+      - $ref: "../swagger.yaml#/parameters/q_body"
>+      - $ref: "../swagger.yaml#/parameters/request_id_header"
>       - name: effective
>         in: query
>         description: Boolean indicating whether to return effective rules or all rules. Defaults to true.
>@@ -42,7 +49,10 @@
>           items:
>             $ref: "../swagger.yaml#/definitions/circulation_rules"
>       "400":
>-        description: Bad request
>+        description: |
>+          Bad request. Possible `error_code` attribute values:
>+
>+            * `invalid_query`
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>       "401":
>@@ -91,8 +101,7 @@
>           items:
>             $ref: "../swagger.yaml#/definitions/circulation_rules"
>       "400":
>-        description: |
>-          Bad request.
>+        description: Bad request
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>       "403":
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 10190: 170357 | 170358 | 170359 | 170360 | 170361 | 170362 | 170363 | 170364 | 170365 | 170366 | 170367 | 170368 | 170369 | 170370 | 170371 | 170372 | 170373 | 170374 | 170375 | 170376 | 170380 | 170449 | 171727 | 171728 | 171729 | 171730 | 171731 | 171732 | 171733 | 171734 | 171735 | 171736 | 171737 | 171738 | 171739 | 171740 | 171741 | 171742 | 171743 | 171744 | 171745 | 171746 | 171747 | 171748 | 171749 | 171750 | 171751 | 171752 | 171753 | 171754 | 171755 | 172588 | 172589 | 172590 | 172591 | 172592 | 172593 | 172594 | 172595 | 172596 | 172597 | 172598 | 172599 | 172600 | 172601 | 172602 | 172603 | 172604 | 172605 | 172606 | 172607 | 172608 | 172609 | 172612 | 172614 | 172617 | 172619 | 172621 | 172622 | 172623 | 172624 | 172625 | 172626 | 172630 | 172631 | 172632 | 172633 | 172634 | 172635 | 172636 | 172637 | 172638 | 172639 | 172640 | 172641 | 172642 | 172643 | 172644 | 172645 | 172646 | 172647 | 172648 | 172649 | 172650 | 172651 | 172652 | 172653 | 172654 | 172655 | 172656 | 172657 | 172658 | 172659 | 172660 | 172661 | 172662 | 172663