Attachment 171777 Details for Bug 37526 – Bug 37526: Add tests

[patch] Bug 37526: Add tests

Bug-37526-Add-tests.patch (text/plain), 3.22 KB, created by Pedro Amorim on 2024-09-19 14:31:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-09-19 14:31:30 UTC

Size: 3.22 KB

patch

obsolete

>From 9070b7cdfb18e83820900eb370bbc45cec4efdd2 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 19 Sep 2024 14:28:47 +0000
>Subject: [PATCH] Bug 37526: Add tests
>
>---
> .../Koha/BackgroundJob/ErmSushiHarvester.t    | 58 ++++++++++++++++++-
> 1 file changed, 57 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t b/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
>index 3b29296342..8101dbf53e 100755
>--- a/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
>+++ b/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 4;
>+use Test::More tests => 5;
> 
> use Koha::Database;
> use Koha::BackgroundJobs;
>@@ -175,6 +175,42 @@ subtest 'multiple_exceptions() tests' => sub {
>     $schema->storage->txn_rollback;
> };
> 
>+subtest 'is_redirect() tests' => sub {
>+
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $ua = Test::MockModule->new('LWP::UserAgent');
>+    $ua->mock('simple_request', sub {
>+            return mock_HTTP_redirect();
>+    });
>+    $ua->mock('get', sub {
>+        return mock_sushi_response({'error'=>'invalid_api_key'});
>+    });
>+
>+    my $usage_data_provider = $builder->build_object(
>+        { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { name => 'TestProvider' } } );
>+
>+    my $job_args = {
>+            ud_provider_id   => $usage_data_provider->erm_usage_data_provider_id,
>+            report_type      => 'TR_J1',
>+            begin_date       => '2023-08-01',
>+            end_date         => '2023-09-30',
>+            ud_provider_name => $usage_data_provider->name,
>+        };
>+
>+    my $job_id = Koha::BackgroundJob::ErmSushiHarvester->new->enqueue($job_args);
>+    my $job = Koha::BackgroundJobs->find($job_id)->_derived_class;
>+    $job->process( $job_args );
>+    
>+    is( $job->{messages}[0]->{message}, decode_json($sushi_response_errors->{invalid_api_key})->{Severity} . ' - ' . decode_json($sushi_response_errors->{invalid_api_key})->{Message},'SUSHI error invalid_date_arguments is stored on job messages correctly' );
>+    is( $job->{messages}[0]->{type},'error','SUSHI error invalid_date_arguments is stored on job messages correctly' );
>+    is( $job->{messages}[0]->{code},decode_json($sushi_response_errors->{invalid_api_key})->{Code},'SUSHI error invalid_date_arguments is stored on job messages correctly' );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
> sub mock_sushi_response {
>     my ($args) = @_;
>     my $response = Test::MockObject->new();
>@@ -191,4 +227,24 @@ sub mock_sushi_response {
>     $response->mock('decoded_content', sub {
>         return $args->{error} ? $sushi_response_errors->{$args->{error}} : $sushi_response_exceptions->{$args->{exception}};
>     });
>+}
>+
>+sub mock_HTTP_redirect {
>+    my $response = Test::MockObject->new();
>+
>+    $response->mock('code', sub {
>+        return 301;
>+    });
>+    $response->mock('is_error', sub {
>+        return 0;
>+    });
>+    $response->mock('is_redirect', sub {
>+        return 1;
>+    });
>+    $response->mock('header', sub {
>+        return 'www.whatever.com';
>+    });
>+    $response->mock('decoded_content', sub {
>+        return 'Moved permanently';
>+    });
> }
>\ No newline at end of file
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37526: 169858 | 170381 | 171777 | 171778 | 171891 | 171892 | 172055 | 172056 | 172057