Bugzilla – Attachment 171797 Details for
Bug 37968
Add ability to store branchcode for messages in the queue and send by branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37968: Tidy code
Bug-37968-Tidy-code.patch (text/plain), 2.84 KB, created by
Kyle M Hall (khall)
on 2024-09-19 19:06:35 UTC
(
hide
)
Description:
Bug 37968: Tidy code
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-09-19 19:06:35 UTC
Size:
2.84 KB
patch
obsolete
>From d269f416c657966f2e3e556b48db0d1fac80fd00 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 19 Sep 2024 15:04:44 -0400 >Subject: [PATCH] Bug 37968: Tidy code > >--- > C4/Letters.pm | 4 +-- > misc/cronjobs/process_message_queue.pl | 36 +++++++++++++------------- > 2 files changed, 20 insertions(+), 20 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index a85a1db905c..7e8d9775a9b 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1018,8 +1018,8 @@ Returns number of messages sent. > > sub SendQueuedMessages { > my $params = shift; >- my $limit = $params->{limit}; >- my $where = $params->{where}; >+ my $limit = $params->{limit}; >+ my $where = $params->{where}; > my $branchcode = $params->{branchcode}; > > Koha::Exceptions::BadParameter->throw("Parameter message_id cannot be empty if passed.") >diff --git a/misc/cronjobs/process_message_queue.pl b/misc/cronjobs/process_message_queue.pl >index ade08426e0b..9c1aecadff4 100755 >--- a/misc/cronjobs/process_message_queue.pl >+++ b/misc/cronjobs/process_message_queue.pl >@@ -26,31 +26,31 @@ use C4::Log qw( cronlogaction ); > use Getopt::Long qw( GetOptions ); > use Try::Tiny qw( catch try ); > >-my $username = undef; >-my $password = undef; >-my $limit = undef; >+my $username = undef; >+my $password = undef; >+my $limit = undef; > my $branchcode = undef; >-my $method = 'LOGIN'; >-my $help = 0; >-my $verbose = 0; >+my $method = 'LOGIN'; >+my $help = 0; >+my $verbose = 0; > my $where; > my @type; > my @letter_code; > my $exit_on_plugin_failure = 0; > >-my $command_line_options = join(" ",@ARGV); >+my $command_line_options = join( " ", @ARGV ); > > GetOptions( >- 'u|username:s' => \$username, >- 'p|password:s' => \$password, >- 'l|limit:s' => \$limit, >- 'b|branchcode:s' => \$branchcode, >- 'm|method:s' => \$method, >- 'h|help|?' => \$help, >- 'v|verbose' => \$verbose, >- 't|type:s' => \@type, >- 'c|code:s' => \@letter_code, >- 'w|where:s' => \$where, >+ 'u|username:s' => \$username, >+ 'p|password:s' => \$password, >+ 'l|limit:s' => \$limit, >+ 'b|branchcode:s' => \$branchcode, >+ 'm|method:s' => \$method, >+ 'h|help|?' => \$help, >+ 'v|verbose' => \$verbose, >+ 't|type:s' => \@type, >+ 'c|code:s' => \@letter_code, >+ 'w|where:s' => \$where, > 'e|exit-on-plugin-failure' => \$exit_on_plugin_failure, > ); > my $usage = << 'ENDUSAGE'; >@@ -130,7 +130,7 @@ C4::Letters::SendQueuedMessages( > type => \@type, > letter_code => \@letter_code, > where => $where, >- branchcode => $branchcode, >+ branchcode => $branchcode, > } > ); > >-- >2.39.2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=171797">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37968
:
171793
|
171794
|
171795
|
171796
| 171797