Attachment 171826 Details for Bug 37892 – Bug 37892: (QA follow-up) Fix condition in memberentry

[patch] Bug 37892: (QA follow-up) Fix condition in memberentry

Bug-37892-QA-follow-up-Fix-condition-in-memberentr.patch (text/plain), 1.08 KB, created by Marcel de Rooy on 2024-09-20 09:09:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-09-20 09:09:46 UTC

Size: 1.08 KB

patch

obsolete

>From c192f0b006a60bac327f9887caf5cac498fb7338 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 20 Sep 2024 09:07:42 +0000
>Subject: [PATCH] Bug 37892: (QA follow-up) Fix condition in memberentry
>Content-Type: text/plain; charset=utf-8
>
>Patron may be undefined. So the test may crash.
>Also there is an issue with operator precedence.
>---
> members/memberentry.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 0d09b16bbd..7b9788f20f 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -285,7 +285,9 @@ if (   ( $op eq 'cud-save' || $op eq 'cud-insert' )
> }
> 
> foreach my $guarantor (@guarantors) {
>-    if ( ( $op eq 'cud-save' || $op eq 'cud-insert' ) && ($guarantor->is_child ) || $guarantor->is_guarantee || $patron->is_guarantor)  {
>+    if (   ( $op eq 'cud-save' || $op eq 'cud-insert' )
>+        && ( $guarantor->is_child || $guarantor->is_guarantee || ( $patron && $patron->is_guarantor ) ) )
>+    {
>         push @errors, 'ERROR_guarantor_is_guarantee';
>     }
> }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37892: 171334 | 171335 | 171336 | 171337 | 171451 | 171463 | 171464 | 171465 | 171466 | 171467 | 171472 | 171475 | 171476 | 171477 | 171478 | 171479 | 171480 | 171546 | 171547 | 171548 | 171549 | 171550 | 171663 | 171664 | 171665 | 171824 | 171825 | 171826 | 172896 | 172897 | 172898