Bugzilla – Attachment 171853 Details for
Bug 36694
Remove HC Sticky library in favor of CSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36694: Remove HC sticky from acqui/basket.tt
Bug-36694-Remove-HC-sticky-from-acquibaskettt.patch (text/plain), 2.69 KB, created by
Victor Grousset/tuxayo
on 2024-09-23 03:18:47 UTC
(
hide
)
Description:
Bug 36694: Remove HC sticky from acqui/basket.tt
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-09-23 03:18:47 UTC
Size:
2.69 KB
patch
obsolete
>From f86349c61268e9453d6dddf97bdae41a33668c86 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 24 Apr 2024 22:45:50 +0000 >Subject: [PATCH] Bug 36694: Remove HC sticky from acqui/basket.tt > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss | 6 ++++++ > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 12 +----------- > 2 files changed, 7 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss >index 6246b5cff2..73dced4d02 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss >@@ -22,6 +22,12 @@ > z-index: 100; > } > >+ &.sticky { >+ position: sticky; >+ top: 0; >+ z-index: 999; >+ } >+ > .btn { > &.btn-default { > font-weight: normal; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index a9f2d15681..b7df301861 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -81,7 +81,7 @@ > [% UNLESS ( selectbasketg ) %] > [% UNLESS ( closedate ) %] > [% UNLESS ( delete_confirmed ) %] >- <div id="toolbar" class="btn-toolbar fh-fixedHeader"> >+ <div id="toolbar" class="btn-toolbar sticky fh-fixedHeader"> > [% IF active %] > <div class="btn-group"><a href="#addtoBasket" role="button" class="btn btn-default" data-bs-toggle="modal"><i class="fa fa-plus"></i> Add to basket</a></div> > [% END %] >@@ -1009,7 +1009,6 @@ > [% Asset.js("js/acquisitions-menu.js") | $raw %] > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'columns_settings.inc' %] >- [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %] > [% Asset.js("js/acq.js") | $raw %] > [% INCLUDE 'calendar.inc' %] > <script> >@@ -1025,16 +1024,7 @@ > } > } > >- var Sticky; >- > $(document).ready(function() { >- if ( $('#toolbar').length ) { >- Sticky = $("#toolbar"); >- Sticky.hcSticky({ >- stickTo: "main", >- stickyClass: "floating" >- }); >- } > > [% UNLESS ( closedate ) %] > $('#addtoBasket').on('show', function () { >-- >2.46.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36694
:
165489
|
165490
|
165491
|
165492
|
165493
|
165576
|
165582
|
165584
|
165587
|
165680
|
165682
|
165683
|
165684
|
165686
|
165756
|
165757
|
165758
|
165759
|
165760
|
165761
|
165762
|
165763
|
165764
|
165765
|
165766
|
165767
|
166703
|
166704
|
166705
|
166706
|
166707
|
166708
|
166709
|
166710
|
166711
|
166712
|
166713
|
166714
|
166715
|
166940
|
167507
|
167508
|
167509
|
167510
|
167511
|
167512
|
167513
|
167514
|
167515
|
167516
|
167517
|
167518
|
167519
|
167520
|
167539
|
167823
|
167824
|
167825
|
167826
|
167827
|
167828
|
167829
|
167830
|
167831
|
167832
|
167833
|
167834
|
167835
|
167836
|
167837
|
169110
|
169111
|
169112
|
169113
|
169114
|
169115
|
169116
|
169117
|
169118
|
169119
|
169120
|
169121
|
169122
|
169123
|
169124
|
169125
|
171080
|
171081
|
171082
|
171083
|
171084
|
171085
|
171086
|
171087
|
171088
|
171089
|
171090
|
171091
|
171092
|
171093
|
171094
|
171095
|
171852
| 171853 |
171854
|
171855
|
171856
|
171857
|
171858
|
171859
|
171860
|
171861
|
171862
|
171863
|
171864
|
171865
|
171866
|
171867