Attachment 171912 Details for Bug 37728 – Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op

[patch] Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op

Bug-37728-follow-up-Tell-the-test-that-opac-illreq.patch (text/plain), 2.40 KB, created by Phil Ringnalda on 2024-09-24 02:47:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2024-09-24 02:47:07 UTC

Size: 2.40 KB

patch

obsolete

>From 3a2e687116209849a6f50b8b707db1e71868fbfd Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Mon, 23 Sep 2024 19:40:32 -0700
>Subject: [PATCH] Bug 37728: (follow-up) Tell the test that opac-illrequests.tt
> has an op
>
>xt/find-missing-op-in-forms.t wants to see name="op" value="cud-..." in any
>form with method="post", but opac-illrequests.tt inserts its op input by
>passing around whole and unpack and repacking whole.keys which includes
>the op. We just need to tell the test that it really exists.
>
>At first, I thought of this approach as a joke, faking out the test, but
>when I tried to be more responsible and put a whole <input type="hidden" etc.
>in the comment, I realized that would be more likely to confuse someone
>who thought that was uncommented and that they were making real changes than
>it would be to future-proof against changes in the test's approach.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
>index 0e6b3d5932..5fc3510940 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
>@@ -258,6 +258,7 @@
>                             <h1>Interlibrary loan item availability</h1>
>                             <div id="results">
>                                 <form method="POST" action="/cgi-bin/koha/opac-illrequests.pl">
>+                                    [%# This will get its name="op" value="cud-" from the loop over whole.keys below %]
>                                     [% INCLUDE 'csrf-token.inc' %]
>                                     <legend><h2>Displaying availability results</h2></legend>
>                                     [% FOREACH key IN whole.keys %]
>@@ -291,6 +292,7 @@
>                             <div id="results" class="page-section">
>                                 [% INCLUDE messages %]
>                                 <form method="post" id="typedisclaimer-form">
>+                                    [%# This will get its name="op" value="cud-" from the loop over whole.keys below %]
>                                     [% INCLUDE 'csrf-token.inc' %]
>                                     <fieldset class="rows">
>                                         [% disclaimer.text | $raw %]
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 37728: 170701 | 171912 | 171913 | 171916 | 171917 | 171922 | 171923