Attachment 171914 Details for Bug 37981 – Bug 37981: Switch installer/step3.tt form from POST to GET

[patch] Bug 37981: Switch installer/step3.tt form from POST to GET

Bug-37981-Switch-installerstep3tt-form-from-POST-t.patch (text/plain), 1.42 KB, created by Phil Ringnalda on 2024-09-24 02:57:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2024-09-24 02:57:17 UTC

Size: 1.42 KB

patch

obsolete

>From 639449ebc0cfe8a6cb4a4edd11265f9522b993e9 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 23 Sep 2024 11:03:33 +0200
>Subject: [PATCH] Bug 37981: Switch installer/step3.tt form from POST to GET
>
>This form does not need to be a POSTed form.
>
>Test plan:
>Drop and recreate the DB and run the web installer.
>Everything should work, no behaviour change expected.
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
>index 412f547ba6..a0c7081036 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
>@@ -291,8 +291,7 @@
>                             </ol>
>                         </div>
> 
>-                        <form action="/cgi-bin/koha/installer/install.pl" method="post">
>-                            [% INCLUDE 'csrf-token.inc' %]
>+                        <form action="/cgi-bin/koha/installer/install.pl" method="get">
>                             <input type="hidden" name="step" value="3" />
>                             <p><input value="Continue to the next step" class="btn btn-primary" type="submit" /></p>
>                         </form>
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 37981: 171871 | 171910 | 171914 | 171920