Attachment 171917 Details for Bug 37728 – Bug 37728: Adjust test to catch more missing 'op' in POSTed forms

[patch] Bug 37728: Adjust test to catch more missing 'op' in POSTed forms

Bug-37728-Adjust-test-to-catch-more-missing-op-in-.patch (text/plain), 1.61 KB, created by Jonathan Druart on 2024-09-24 04:07:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-09-24 04:07:16 UTC

Size: 1.61 KB

patch

obsolete

>From a5aecf7767bdd2c2069e3b2354c1d5e29d4de284 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 26 Aug 2024 11:03:05 +0200
>Subject: [PATCH] Bug 37728: Adjust test to catch more missing 'op' in POSTed
> forms
>
>The test is not catching missing op in forms that are not the first POST
>form of the template.
>
>Found when fixing the test for bug 37309. It was not catching the
>missing op in the second form.
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>---
> xt/find-missing-op-in-forms.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/xt/find-missing-op-in-forms.t b/xt/find-missing-op-in-forms.t
>index 3958a1fbd32..483601f8e38 100755
>--- a/xt/find-missing-op-in-forms.t
>+++ b/xt/find-missing-op-in-forms.t
>@@ -50,7 +50,7 @@ sub catch_missing_op {
>     my @lines = read_file($file);
>     my @errors;
>     return unless grep { $_ =~ m|<form| } @lines;
>-    my ( $in_form, $closed_form, $line_open_form, $has_op, $op_value );
>+    my ( $in_form, $line_open_form, $has_op, $op_value );
>     my $line_number = 0;
>     for my $line (@lines) {
>         $line_number++;
>@@ -65,7 +65,6 @@ sub catch_missing_op {
>             }
>         }
>         if ( $in_form && $line =~ m{</form} ) {
>-            $closed_form = 0;
>             if ($has_op) {
>                 if ( $op_value !~ m{^cud-} && $op_value !~ m{^\[%} ) {
>                     push @errors, $line_open_form;
>@@ -73,6 +72,7 @@ sub catch_missing_op {
>             } else {
>                 push @errors, $line_open_form;
>             }
>+            $has_op = 0;
>             $in_form = 0;
>         }
>     }
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37728: 170701 | 171912 | 171913 | 171916 | 171917 | 171922 | 171923