Attachment 171921 Details for Bug 37982 – Bug 37982: Replace edit form with GET

[patch] Bug 37982: Replace edit form with GET

Bug-37982-Replace-edit-form-with-GET.patch (text/plain), 2.18 KB, created by Pedro Amorim on 2024-09-24 09:49:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-09-24 09:49:51 UTC

Size: 2.18 KB

patch

obsolete

>From 80f959091a4f78e001ccf9221abaa6d6c7edbc6a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 23 Sep 2024 11:13:45 +0200
>Subject: [PATCH] Bug 37982: Replace edit form with GET
>
>Caught by tests from bug 37728
>
> # $VAR3 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:158';
>
>We don't really need the form to be POSTed, we should not reach the URL maxlength.
>The UI will certainly explode if there are lot of items to edit anyway.
>The code is not clear on this page as we are sending several forms using
>the items selected from this table. But this one form is used to display
>the edit form and so can be GET (and better as the URL can be shared).
>The other actions have their own form (in modals mostly).
>
>Test plan:
>Create a subscription and go to the serial collection page.
>Make sure at least one item is select and click the "Edit" button.
>No behaviour change expected here, the edit form should still be
>displayed.
>Try the other actions on top of the table and confirm they are still
>working as before.
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> .../prog/en/modules/serials/serials-collection.tt              | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>index 7d4d6954f83..958b00837ed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>@@ -155,8 +155,7 @@
>                 [% END # /IF subscriptions %]
> 
>                 [% IF ( years ) %]
>-                    <form name="edition" action="/cgi-bin/koha/serials/serials-edit.pl" method="post">
>-                        [% INCLUDE 'csrf-token.inc' %]
>+                    <form name="edition" action="/cgi-bin/koha/serials/serials-edit.pl" method="get">
>                         [% WRAPPER tabs id= "subscription_years" %]
>                             [% WRAPPER tabs_nav %]
>                                 [% FOREACH year IN years %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37982: 171872 | 171911 | 171921