Bugzilla – Attachment 171935 Details for
Bug 36798
Add ability to search across all ISBNs using the ISBN-search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36798: Add 'SearchCancelledAndInvalidISBNandISSN' system preference
Bug-36798-Add-SearchCancelledAndInvalidISBNandISSN.patch (text/plain), 4.22 KB, created by
Lucas Gass (lukeg)
on 2024-09-24 13:51:34 UTC
(
hide
)
Description:
Bug 36798: Add 'SearchCancelledAndInvalidISBNandISSN' system preference
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-09-24 13:51:34 UTC
Size:
4.22 KB
patch
obsolete
>From 3d899dc2f6a81e91df3d6ffa14e5366ae6c7c709 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Tue, 14 May 2024 13:06:05 +0000 >Subject: [PATCH] Bug 36798: Add 'SearchCancelledAndInvalidISBNandISSN' system > preference > >This patch adds a new system preference SearchCancelledAndInvalidISBNandISSN: >whether to search for cancelled / invalid forms of ISBN/ISSN >when performing ISBN/ISSN search. (By default, with ES, only valid forms, >i.e. 020 $a / 022 $a are considered). > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../data/mysql/atomicupdate/bug_36798.pl | 21 +++++++++++++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 1 + > .../modules/admin/preferences/searching.pref | 7 +++++++ > 3 files changed, 29 insertions(+) > create mode 100755 installer/data/mysql/atomicupdate/bug_36798.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_36798.pl b/installer/data/mysql/atomicupdate/bug_36798.pl >new file mode 100755 >index 00000000000..31b5fac954b >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_36798.pl >@@ -0,0 +1,21 @@ >+use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_failure say_success say_info); >+ >+return { >+ bug_number => "36798", >+ description => "Add `SearchCancelledAndInvalidISBNandISSN` preference", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ # Do you stuffs here >+ $dbh->do( >+ q{ >+ INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) >+ VALUES ('SearchCancelledAndInvalidISBNandISSN','0',NULL,'Enable search for cancelled or invalid forms of ISBN/ISSN when performing ISBN/ISSN search (when using ES)','YesNo') >+ } >+ ); >+ >+ say_success( $out, "Added new system preference 'SearchCancelledAndInvalidISBNandISSN'" ); >+ }, >+}; >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 20d11d36ab3..25f87041673 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -690,6 +690,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('SCOLoadCheckoutsByDefault','1','','If enabled, load the list of a patrons checkouts when they log in to the Self Checkout','YesNo'), > ('SCOUserCSS','',NULL,'Add CSS to be included in the SCO module in an embedded <style> tag.','free'), > ('SCOUserJS','',NULL,'Define custom javascript for inclusion in the SCO module','free'), >+('SearchCancelledAndInvalidISBNandISSN','0',NULL,'Enable search for cancelled or invalid forms of ISBN/ISSN when performing ISBN/ISSN search (when using ES)','YesNo'), > ('SearchEngine','Zebra','Elasticsearch|Zebra','Search Engine','Choice'), > ('SearchLimitLibrary', 'homebranch', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice'), > ('SearchMyLibraryFirst','0',NULL,'If ON, OPAC searches return results limited by the user\'s library by default if they are logged in','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >index e697058880e..1f334e2da10 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >@@ -106,6 +106,13 @@ Searching: > - "List of search fields (separated by | or ,) that should not be autotruncated by Elasticsearch even if <a href='/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=QueryAutoTruncate'>QueryAutoTruncate</a> is set to 'Yes':" > - pref: ESPreventAutoTruncate > class: long >+ - >+ - pref: SearchCancelledAndInvalidISBNandISSN >+ default: 0 >+ choices: >+ 1: Do >+ 0: "Don't" >+ - "search for cancelled or invalid forms of ISBN/ISSN when performing ISBN/ISSN search (when using Elasticsearch)." > - > - pref: z3950Status > type: textarea >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36798
:
166828
|
166829
|
166830
|
166836
|
166837
|
166838
|
171906
|
171907
|
171908
| 171935 |
171936
|
171937