Bugzilla – Attachment 171950 Details for
Bug 37967
Allow auto renewals notices to be sent via phone
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37967: Allow auto renewals notices to be sent via phone
Bug-37967-Allow-auto-renewals-notices-to-be-sent-v.patch (text/plain), 2.86 KB, created by
Lucas Gass (lukeg)
on 2024-09-24 19:34:20 UTC
(
hide
)
Description:
Bug 37967: Allow auto renewals notices to be sent via phone
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-09-24 19:34:20 UTC
Size:
2.86 KB
patch
obsolete
>From efdb575ec25b3f7f4475152b583e4e57f1125431 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 19 Sep 2024 14:31:56 -0400 >Subject: [PATCH] Bug 37967: Allow auto renewals notices to be sent via phone > >Auto renewals via phone are only disallowed because itiva did not support them. >There is no reason to disallow auto-reneals for the generic phone transport. >Twilio, for example, would have no problem sending those phone notices. > >Test Plan: >1) Apply this patch >2) Run updatedatabase.pl >3) Note you can now select phone for auto-renewals! > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../data/mysql/atomicupdate/bug_37967.pl | 22 +++++++++++++++++++ > .../sample_notices_message_transports.sql | 2 ++ > 2 files changed, 24 insertions(+) > create mode 100755 installer/data/mysql/atomicupdate/bug_37967.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_37967.pl b/installer/data/mysql/atomicupdate/bug_37967.pl >new file mode 100755 >index 00000000000..9e08f9bcc76 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_37967.pl >@@ -0,0 +1,22 @@ >+use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_failure say_success say_info); >+ >+return { >+ bug_number => "BUG_NUMBER", >+ description => "A single line description", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ try { >+ $dbh->do(q{ >+ INSERT IGNORE INTO message_transports (`message_attribute_id`, `message_transport_type`, `is_digest`, `letter_module`, `letter_code`) VALUES >+ (9, 'phone', 1, 'circulation', 'AUTO_RENEWALS_DGST'), >+ (9, 'phone', 0, 'circulation', 'AUTO_RENEWALS'); >+ }); >+ say_success( $out, "Added phone messaging transports for auto-renewals" ); >+ } catch { >+ say_failure( $out, "Error adding phone messaging transports for auto-renewals: $_" ); >+ }; >+ }, >+}; >diff --git a/installer/data/mysql/mandatory/sample_notices_message_transports.sql b/installer/data/mysql/mandatory/sample_notices_message_transports.sql >index 977e59f5eae..762fdb7ee50 100644 >--- a/installer/data/mysql/mandatory/sample_notices_message_transports.sql >+++ b/installer/data/mysql/mandatory/sample_notices_message_transports.sql >@@ -36,8 +36,10 @@ values > (8, 'phone', 0, 'ill', 'ILL_REQUEST_UNAVAIL'), > (9, 'email', 0, 'circulation', 'AUTO_RENEWALS'), > (9, 'sms', 0, 'circulation', 'AUTO_RENEWALS'), >+(9, 'phone', 0, 'circulation', 'AUTO_RENEWALS'), > (9, 'email', 1, 'circulation', 'AUTO_RENEWALS_DGST'), > (9, 'sms', 1, 'circulation', 'AUTO_RENEWALS_DGST'), >+(9, 'phone', 1, 'circulation', 'AUTO_RENEWALS_DGST'), > (10, 'email', 0, 'circulation', 'HOLD_REMINDER'), > (10, 'sms', 0, 'circulation', 'HOLD_REMINDER'), > (10, 'phone', 0, 'circulation', 'HOLD_REMINDER'), >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37967
:
171791
|
171792
|
171808
| 171950 |
171951