Bugzilla – Attachment 171953 Details for
Bug 37637
Use the REST API to display items on the staff edit items view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37637: (follow-up) Fix action menu
Bug-37637-follow-up-Fix-action-menu.patch (text/plain), 5.43 KB, created by
Lucas Gass (lukeg)
on 2024-09-24 20:00:03 UTC
(
hide
)
Description:
Bug 37637: (follow-up) Fix action menu
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-09-24 20:00:03 UTC
Size:
5.43 KB
patch
obsolete
>From 1a093f184500ed9e429f6c47702bbaa2c76fc584 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 24 Sep 2024 19:59:27 +0000 >Subject: [PATCH] Bug 37637: (follow-up) Fix action menu > >--- > .../intranet-tmpl/prog/js/cataloging_additem.js | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >index 7c7bde3f15c..615ad3c8a08 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >@@ -315,19 +315,19 @@ function build_itemst(show_filters, dt_options) { > if (can_be_edited) { > nodes += '<td>' > nodes += '<div class="btn-group dropup">'; >- nodes += '<a class="btn btn-default btn-xs dropdown-toggle" id="itemactions' + row.item_id + '" role="button" data-toggle="dropdown" href="#">'; >+ nodes += '<a class="btn btn-default btn-xs dropdown-toggle" id="itemactions' + row.item_id + '" role="button" data-bs-toggle="dropdown" href="#">'; > nodes += 'Actions <b class="caret"></b>'; > nodes += '</a>'; > nodes += '<ul class="dropdown-menu" role="menu" aria-labelledby="itemactions' + row.item_id + '">'; > if (row.biblio_id != biblionumber) { // Host item >- nodes += '<li><a href="additem.pl?op=edititem&biblionumber=' + row.biblio_id + '&itemnumber=' + row.item_id + '#edititem">Edit in host</a> <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=' + row.biblio_id + '&hostitemnumber=' + row.item_id + '&searchid=' + row.searchid + '">Delink</a></li>'; >+ nodes += '<li><a class="dropdown-item" href="additem.pl?op=edititem&biblionumber=' + row.biblio_id + '&itemnumber=' + row.item_id + '#edititem">Edit in host</a> <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=' + row.biblio_id + '&hostitemnumber=' + row.item_id + '&searchid=' + row.searchid + '">Delink</a></li>'; > } else { > if (can_edit_items_from.includes(row.home_library_id) || !can_edit_items_from.length) { >- nodes += '<li><a href="additem.pl?op=edititem&biblionumber=' + row.biblio_id + '&itemnumber=' + row.item_id + '&searchid=' + row.searchid + '#edititem">Edit</a></li>'; >+ nodes += '<li><a class="dropdown-item" href="additem.pl?op=edititem&biblionumber=' + row.biblio_id + '&itemnumber=' + row.item_id + '&searchid=' + row.searchid + '#edititem">Edit</a></li>'; > } >- nodes += '<li><a href="additem.pl?op=dupeitem&biblionumber=' + row.biblio_id + '&itemnumber=' + row.item_id + '&searchid=' + row.searchid + '#additema">Duplicate</a></li>'; >+ nodes += '<li><a class="dropdown-item" href="additem.pl?op=dupeitem&biblionumber=' + row.biblio_id + '&itemnumber=' + row.item_id + '&searchid=' + row.searchid + '#additema">Duplicate</a></li>'; > nodes += '<li class="print_label">'; >- nodes += '<a class="submit-form-link" target="_blank" href="#" data-op="cud-add" data-number_list="' + row.item_id + '" data-number_type="itemnumber" data-method="post" data-action="/cgi-bin/koha/labels/label-edit-batch.pl" data-new_tab="true">Print label</a>'; >+ nodes += '<a class="dropdown-item submit-form-link" target="_blank" href="#" data-op="cud-add" data-number_list="' + row.item_id + '" data-number_type="itemnumber" data-method="post" data-action="/cgi-bin/koha/labels/label-edit-batch.pl" data-new_tab="true">Print label</a>'; > nodes += '</li>'; > if (can_edit_items_from.includes(row.home_library_id) || !can_edit_items_from.length) { > let csrfToken = $('meta[name="csrf-token"]').attr('content'); >@@ -339,13 +339,13 @@ function build_itemst(show_filters, dt_options) { > nodes += '<input type="hidden" name="itemnumber" value="' + row.item_id + '" />'; > nodes += '<input type="hidden" name="searchid" value="' + row.searchid + '" />'; > nodes += '</form>'; >- nodes += '<a class="delete" data-item="' + row.item_id + '" href="#">Delete</a>'; >+ nodes += '<a class="dropdown-item delete" data-item="' + row.item_id + '" href="#">Delete</a>'; > nodes += '</li>'; > } > } > if ( opac_base_url ) { > var href = opac_base_url + "/cgi-bin/koha/opac-detail.pl?biblionumber=" + row.biblio_id; >- nodes+= '<li class="view-in-opac"><a target="_blank" href="' + href + '">OPAC view</a></li>' >+ nodes+= '<li class="view-in-opac"><a class="dropdown-item" target="_blank" href="' + href + '">OPAC view</a></li>' > } > nodes += '</ul>'; > nodes += '</div>'; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37637
:
170482
|
170483
|
170507
|
170789
|
170790
| 171953