Bugzilla – Attachment 171965 Details for
Bug 37988
Accessibility: The 'Home' icon in the staff interface cannot be accessed with a keyboard
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37988: [Alternate] Use Bootstrap 5 class .visually-hidden-focusable
Bug-37988-Alternate-Use-Bootstrap-5-class-visually.patch (text/plain), 2.54 KB, created by
Owen Leonard
on 2024-09-26 13:04:45 UTC
(
hide
)
Description:
Bug 37988: [Alternate] Use Bootstrap 5 class .visually-hidden-focusable
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-09-26 13:04:45 UTC
Size:
2.54 KB
patch
obsolete
>From ed11bd6eb667784baf673dcf50e28f0f4d70c202 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 24 Sep 2024 13:49:17 +0000 >Subject: [PATCH] Bug 37988: [Alternate] Use Bootstrap 5 class > .visually-hidden-focusable > >It looks to me like we can remove the visibility properties from the >home button CSS and wrap the text in a <span> with Bootstrap 5's >"visually-hidden-focusable" class: > >https://getbootstrap.com/docs/5.3/getting-started/accessibility/#visually-hidden-content > >That appears to give us the behavior we want: A focusable icon which >isn't obscured by the focus border. > >To test, apply the patch and rebuild the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). > >In the staff interface, test some pages by using tab or shift-tab to >move between elements on the page to confirm that the home icon can be >tabbed to. >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 4 ---- > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index b708bd36bf7..2648926808c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -2962,9 +2962,6 @@ nav { > a { > &[href="/cgi-bin/koha/mainpage.pl"] { > color: $green-text-color; >- font-size: 1px; >- letter-spacing: -1px; >- visibility: hidden; > > &::before { > content: "\f015"; >@@ -2972,7 +2969,6 @@ nav { > font-size: 12px; > font-style: normal; > padding-right: .3em; >- visibility: visible; > } > > &:hover { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 16736e5c1a2..4c35dc22c5f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -461,7 +461,7 @@ > <ol class="breadcrumb"> > [%# Include the Home link every time %] > [% WRAPPER breadcrumb_item %] >- <a href="/cgi-bin/koha/mainpage.pl" title="Home">Home</a> >+ <a href="/cgi-bin/koha/mainpage.pl" title="Home"><span class="visually-hidden-focusable">Home</span></a> > [% END %] > [% content | $raw %] > </ol> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37988
:
171880
|
171965
|
171987
|
171990
|
173544