Attachment 171989 Details for Bug 24720 – Bug 24720: Add test

[patch] Bug 24720: Add test

Bug-24720-Add-test.patch (text/plain), 2.59 KB, created by Shi Yao Wang on 2024-09-26 15:38:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shi Yao Wang

Created: 2024-09-26 15:38:31 UTC

Size: 2.59 KB

patch

obsolete

>From c4b1c1a06b15a003dc2b5281894b5de2b44a788a Mon Sep 17 00:00:00 2001
>From: David Gustafsson <glasklas@gmail.com>
>Date: Fri, 10 Sep 2021 15:07:47 +0200
>Subject: [PATCH] Bug 24720: Add test
>
>Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
>---
> .../Koha/SearchEngine/Elasticsearch.t         | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch.t
>index 48cd2025d8..d01e58855f 100755
>--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch.t
>+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch.t
>@@ -186,7 +186,7 @@ subtest 'get_elasticsearch_mappings() tests' => sub {
> 
> subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' => sub {
> 
>-    plan tests => 66;
>+    plan tests => 67;
> 
>     t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
>     t::lib::Mocks::mock_preference('ElasticsearchMARCFormat', 'ISO2709');
>@@ -293,6 +293,16 @@ subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests'
>             marc_type => 'marc21',
>             marc_field => '245',
>         },
>+        {
>+            name => 'title_sort',
>+            type => 'string',
>+            facet => 0,
>+            suggestible => 0,
>+            searchable => 0,
>+            sort => 1,
>+            marc_type => 'marc21',
>+            marc_field => '246a',
>+        },
>         {
>             name => 'sum_item_price',
>             type => 'sum',
>@@ -436,6 +446,7 @@ subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests'
>         MARC::Field->new('650', '', '', a => 'Heading', z => 'Geohead', v => 'Formhead'),
>         MARC::Field->new('650', '', '', a => 'Heading', x => 'Gensubhead', z => 'Geohead'),
>         MARC::Field->new('999', '', '', c => '1234567'),
>+        MARC::Field->new('246', '', '', a => '#$[Title!'),
>         # '  ' for testing trimming of white space in boolean value callback:
>         MARC::Field->new('952', '', '', 0 => '  ', g => '123.30', o => $callno, l => 3),
>         MARC::Field->new('952', '', '', 0 => 0, g => '127.20', o => $callno2, l => 2),
>@@ -619,6 +630,12 @@ subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests'
>       'First document copydate field should be set correctly'
>     );
> 
>+    is(
>+        $docs->[0]->{title_sort__sort}[0],
>+        'Title!',
>+        'First document title_sort should have initial non word characters stripped',
>+    );
>+
>     # Second record:
> 
>     is(scalar @{$docs->[1]->{author}}, 1, 'Second document author field should contain one value');
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 24720: 99556 | 111567 | 124759 | 124760 | 125209 | 125210 | 162674 | 171988 | 171989