Bugzilla – Attachment 171997 Details for
Bug 37369
Item search column filtering can't use descriptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37369: Fix filtering of search result table in item search
Bug-37369-Fix-filtering-of-search-result-table-in-.patch (text/plain), 2.13 KB, created by
Lucas Gass (lukeg)
on 2024-09-26 16:14:00 UTC
(
hide
)
Description:
Bug 37369: Fix filtering of search result table in item search
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-09-26 16:14:00 UTC
Size:
2.13 KB
patch
obsolete
>From b05ec325418412d5dbf9be97d4785aa5f10b5f7b Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Thu, 26 Sep 2024 08:22:13 +0300 >Subject: [PATCH] Bug 37369: Fix filtering of search result table in item > search > >At the moment, the filtering on item results page >requires using the code in the following fields: >- Collection >- Home library >- Current library >- Shelving location >- Itemtype >- item status -fields (not for loan etc) > >So e.g. "Centerville" in Home library -field doesn't >bring back results but code "CPL" does. This happens >because "columns" option in search results table >isn't working when its used in function columnFilter. >However option "aoColumns" works. > >To test: >1. Navigate to item search and search items. >=> Note that all filters in search result table >are free text fields. >2. Attempt to filter search results by home library >with description of some library. >=> No results are displayed. >3. Now filter results with code of the library. >=> Results are now displayed. >4. Apply this patch and refresh page. >5. Search items again. >=> Note that now some of the filters are now using >dropdown select fields. >6. Attempt to filter results by home library again. >=> Results are now displayed correctly. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Olivier Hubert <olivier.hubert@inlibro.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index f0eb2666ec1..690d5933837 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -619,7 +619,7 @@ > fixedHeader: false // There is a bug on this view > })).columnFilter({ > 'sPlaceHolder': 'head:after', >- "columns": [ >+ "aoColumns": [ > null, > { 'type': 'text' }, > { 'type': 'text' }, >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37369
:
171960
|
171991
| 171997