Attachment 172045 Details for Bug 37856 – Bug 37856: Consider 'Exceptions' not being part of 'Report_Header'

[patch] Bug 37856: Consider 'Exceptions' not being part of 'Report_Header'

Bug-37856-Consider-Exceptions-not-being-part-of-Re.patch (text/plain), 1.56 KB, created by Nick Clemens (kidclamp) on 2024-09-26 19:22:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-09-26 19:22:08 UTC

Size: 1.56 KB

patch

obsolete

>From 83d5f94915056b23a53f1c6a71c5825a4b59ec59 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 19 Sep 2024 13:55:48 +0000
>Subject: [PATCH] Bug 37856: Consider 'Exceptions' not being part of
> 'Report_Header'
>
>When fixing the issue around the missing platform parameter, we
>noticed this particular provider also returns 'Exceptions' as
>its own thing, not part of 'Report_Header', despite documentation:
>https://countermetrics.stoplight.io/docs/counter-sushi-api/7cp0h7n1hm2en-tr-j1-journal-requests-controlled
>
>From the link above, search for 'Exceptions'. Notice it should be under 'Report_Header'.
>Either way, this patch accounts for this possibility.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/ERM/EUsage/UsageDataProvider.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/ERM/EUsage/UsageDataProvider.pm b/Koha/ERM/EUsage/UsageDataProvider.pm
>index da4171571fd..b9ead5ca864 100644
>--- a/Koha/ERM/EUsage/UsageDataProvider.pm
>+++ b/Koha/ERM/EUsage/UsageDataProvider.pm
>@@ -474,8 +474,9 @@ sub _sushi_errors {
>         return 1;
>     }
> 
>-    if ( $decoded_response->{Report_Header}->{Exceptions} ) {
>-        foreach my $exception ( @{ $decoded_response->{Report_Header}->{Exceptions} } ) {
>+    my $exceptions = $decoded_response->{Report_Header}->{Exceptions} // $decoded_response->{Exceptions};
>+    if ( $exceptions ) {
>+        foreach my $exception ( @{ $exceptions } ) {
>             $self->{job_callbacks}->{add_message_callback}->(
>                 {
>                     type    => 'error',
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37856: 171680 | 171681 | 171682 | 171683 | 171773 | 171774 | 171775 | 171893 | 171894 | 171895 | 171896 | 171897 | 171898 | 171899 | 172040 | 172042 | 172043 | 172044 | 172045 | 172046 | 172047 | 172048 | 172155 | 172156 | 172215