Attachment 172046 Details for Bug 37856 – Bug 37856: Consider absence of 'Report_Items'

[patch] Bug 37856: Consider absence of 'Report_Items'

Bug-37856-Consider-absence-of-ReportItems.patch (text/plain), 1.03 KB, created by Nick Clemens (kidclamp) on 2024-09-26 19:22:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-09-26 19:22:10 UTC

Size: 1.03 KB

patch

obsolete

>From d147944f83e31865a723fc1b8f2f49f4fdfdd363 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 19 Sep 2024 14:00:41 +0000
>Subject: [PATCH] Bug 37856: Consider absence of 'Report_Items'
>
>The SUSHI provider in question for this patchset also does not return any
>Report_Items entry. This patch accounts for that.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/ERM/EUsage/UsageDataProvider.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/ERM/EUsage/UsageDataProvider.pm b/Koha/ERM/EUsage/UsageDataProvider.pm
>index b9ead5ca864..1f094e15d39 100644
>--- a/Koha/ERM/EUsage/UsageDataProvider.pm
>+++ b/Koha/ERM/EUsage/UsageDataProvider.pm
>@@ -488,7 +488,7 @@ sub _sushi_errors {
>         return 1;
>     }
> 
>-    if ( scalar @{ $decoded_response->{Report_Items} } == 0 ) {
>+    if ( $decoded_response->{Report_Items} && scalar @{ $decoded_response->{Report_Items} } == 0 ) {
>         $self->{job_callbacks}->{add_message_callback}->(
>             {
>                 type => 'error',
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37856: 171680 | 171681 | 171682 | 171683 | 171773 | 171774 | 171775 | 171893 | 171894 | 171895 | 171896 | 171897 | 171898 | 171899 | 172040 | 172042 | 172043 | 172044 | 172045 | 172046 | 172047 | 172048 | 172155 | 172156 | 172215