Attachment 172049 Details for Bug 18273 – Bug 18273: Do not insert authority if there already are duplicates in koha

[patch] Bug 18273: Do not insert authority if there already are duplicates in koha

Bug-18273-Do-not-insert-authority-if-there-already.patch (text/plain), 1.62 KB, created by Martin Renvoize (ashimema) on 2024-09-26 19:25:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-09-26 19:25:55 UTC

Size: 1.62 KB

patch

obsolete

>From 0964b4fdc8f47f8c0abb0ce95982b41a10047b5f Mon Sep 17 00:00:00 2001
>From: Matthias Meusburger <matthias.meusburger@biblibre.com>
>Date: Wed, 15 Mar 2017 16:10:45 +0000
>Subject: [PATCH] Bug 18273: Do not insert authority if there already are
> duplicates in koha
>
>Test plan:
>
>1) Create an authority with a unique value in a searchable field, for instance a PERSO_NAME authority with 'BZ18273' in the 100$a field.
>
>2) Create a second authority with the same value in the same field.
>
>3) Export this second authority as iso2709 (Save -> MARC (Unicode/UTF-8))
>
>4) Run bulkmarcimport.pl with the following parameters:
>perl bulkmarcimport.pl -a --file=/kohadevbox/koha/auth-xxxx.utf8 --match='Heading,100$a' -l /kohadevbox/koha/bulk.log
>
>5) Check in the log file and/or through search that a third authority has been added (despite using the --match option)
>
>6) Apply the patch
>
>7) Delete the 3 authorities and repeat step 1 to 4.
>
>8) Check that a third authority has not been added (--match worked)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/migration_tools/bulkmarcimport.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index 8161a0bb0ad..5744d9dff00 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -422,6 +422,7 @@ RECORD: foreach my $record ( @{$marc_records} ) {
>             }
>         } elsif ( @{$results} > 1 ) {
>             $logger->debug("More than one match for: $query");
>+            next;
>         } else {
>             $logger->debug("No match for: $query");
>         }
>-- 
>2.46.1

Actions: View | Diff | Splinter Review

Attachments on bug 18273: 61106 | 144213 | 171385 | 172049