Attachment 172061 Details for Bug 37293 – Bug 37293: MARC bibliographic framework text for librarians and OPAC limited to 100 characters

[patch] Bug 37293: MARC bibliographic framework text for librarians and OPAC limited to 100 characters

Bug-37293-MARC-bibliographic-framework-text-for-li.patch (text/plain), 5.33 KB, created by Shi Yao Wang on 2024-09-26 19:58:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shi Yao Wang

Created: 2024-09-26 19:58:56 UTC

Size: 5.33 KB

patch

obsolete

>From 9c23dd80b8d1fc14e6c343f409741218554cbcef Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Thu, 5 Sep 2024 17:16:28 -0700
>Subject: [PATCH] Bug 37293: MARC bibliographic framework text for librarians
> and OPAC limited to 100 characters
>
>The database columns for liblibrarian and libopac in marc_tag_structure and
>marc_subfield_structure are 255 characters, but the HTML maxlength in
>/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt and
>/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>limit tags to 100 characters and subfields to 80 characters.
>
>Test plan:
> 1. Apply patch, restart_all
> 2. Administration - MARC bibliographic framework - for Default, Actions -
>    MARC Structure
> 3. For the 000 tag, Actions - Edit tag
> 4. In both the "Description in staff interface" and "Description in OPAC"
>    paste the 255 character string
>
>1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 12
>
>    and click Save changes
> 5. Verify that the display shows all 255 characters, then Actions - Edit tag
>    and verify that the two inputs reloaded with all 255 characters, and that
>    you cannot type a 256th character, then click Cancel
> 6. For the 000 tag, Actions - Edit subfields
> 7. Paste the same string in both the staff interface and OPAC inputs, Save
>    changes, verify that all 255 characters show, click Edit subfields, verify
>    that all 255 characters reloaded in the inputs, verify that you cannot
>    type a 256th character
>
>Sponsored-by: Chetco Community Public Library
>Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
>---
> .../prog/en/modules/admin/marc_subfields_structure.tt         | 4 ++--
> .../intranet-tmpl/prog/en/modules/admin/marctagstructure.tt   | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>index 1e0c80eb5c..619b0967aa 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>@@ -148,11 +148,11 @@
>                                                         [% END %]
>                                                         <li>
>                                                             <label for="liblibrarian[% loo.row | html %]">Description in staff interface: </label>
>-                                                            <input id="liblibrarian[% loo.row | html %]" type="text" name="liblibrarian_[% loo.row | html %]" value="[% loo.liblibrarian | html_entity %]" size="40" maxlength="80" />
>+                                                            <input id="liblibrarian[% loo.row | html %]" type="text" name="liblibrarian_[% loo.row | html %]" value="[% loo.liblibrarian | html_entity %]" size="40" maxlength="255" />
>                                                         </li>
>                                                         <li>
>                                                             <label for="libopac[% loo.row | html %]">Description in OPAC: </label>
>-                                                            <input type="text" id="libopac[% loo.row | html %]" name="libopac_[% loo.row | html %]" value="[% loo.libopac | html_entity %]" size="40" maxlength="80" />
>+                                                            <input type="text" id="libopac[% loo.row | html %]" name="libopac_[% loo.row | html %]" value="[% loo.libopac | html_entity %]" size="40" maxlength="255" />
>                                                         </li>
>                                                         <li>
>                                                             <label for="repeatable[% loo.row | html %]">Repeatable: </label>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>index 03e125b3f6..440cc0d184 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>@@ -133,8 +133,8 @@
>                     <span class="required">Required</span>
>                 [% END %]
>             </li>
>-    <li><label for="liblibrarian">Description in staff interface: </label><input type="text" id="liblibrarian" name="liblibrarian" value="[% liblibrarian | html %]" size="40" maxlength="100" /></li>
>-    <li><label for="libopac">Description in OPAC: </label><input type="text" id="libopac" name="libopac" value="[% libopac | html %]" size="40" maxlength="100" /></li>
>+    <li><label for="liblibrarian">Description in staff interface: </label><input type="text" id="liblibrarian" name="liblibrarian" value="[% liblibrarian | html %]" size="40" maxlength="255" /></li>
>+    <li><label for="libopac">Description in OPAC: </label><input type="text" id="libopac" name="libopac" value="[% libopac | html %]" size="40" maxlength="255" /></li>
>     <li><label for="repeatable">Repeatable: </label>
>         [% IF ( repeatable ) %]
>             <input type="checkbox" name="repeatable" id="repeatable" value="1" checked="checked" />
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37293: 171108 | 172061 | 174952