Bugzilla – Attachment 172066 Details for
Bug 33462
Force password change for new patrons entered by staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33462: Add ability to force password change for new patrons entered by staff
Bug-33462-Add-ability-to-force-password-change-for.patch (text/plain), 14.08 KB, created by
Kyle M Hall (khall)
on 2024-09-26 20:15:34 UTC
(
hide
)
Description:
Bug 33462: Add ability to force password change for new patrons entered by staff
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-09-26 20:15:34 UTC
Size:
14.08 KB
patch
obsolete
>From a4e8b06a257d698df9d6d6b9d689b909e9aca383 Mon Sep 17 00:00:00 2001 >From: Sam Lau <samalau@gmail.com> >Date: Fri, 7 Jun 2024 18:44:54 +0000 >Subject: [PATCH] Bug 33462: Add ability to force password change for new > patrons entered by staff > >This patch attempts to force a password change for new staff created patrons. >This is done by setting the password_expiration_date to an expired date when >adding a new patron. This patch adds a new system preference >'ForcePasswordResetWhenSetByStaff' and a new column to the categories table >'force_password_reset_when_set_by_staff. > >To test: >1) Apply patch, restart_all, updatedatabase, and also be sure to update schema. >2) Visit Administration->Sytem Preferences and search for 'EnableExpiredPasswordReset'. > Make sure this is set to enable. Now search for 'ForcePasswordResetWhenSetByStaff'. > This should be defaulted to 'Don't force'. >3) Keep that tab open and visit Administration->Patron categories. Click on edit > on the Board category. Noitce that there is a now a 'Force new patron password reset' > section. Notice that the by default, this is set to follow the > ForcePasswordResetWhenSetByStaff system preference (currently set to don't force). > Click on the dropdown and change it to 'Force'. Save changes >4) Click on the Patrons tab to visit members-home.pl and then click 'New Patron'. > Select on Patron. Fill in the required information and also enter a password. >5) Submit this form and notice that the patron's password expiration date is set > to never. This should be the case because the default for 'Force new patron > password reset' follows the sys. pref. which is still set to 'Don't force' (You > could have some expiry date in this step, but it should at least be set to a > date that is not expired. this depends on whether or not you have a defalut > password expiration date set in patron categories ) >6) Log into the OPAC with this patron and notice it works as expected and log in > was successful. >7) Go back to the patron home page and click to add a new patron. This time select > 'Board'. Once again fill out the required info, enter a password, and then save > the form. >8) Notice that for this patron, the password expiration date is set for today's > date. This is because we changed the setting for the 'Board' patron category to > force. >9) Log into the OPAC with this patron. You should be redirected to a page with an > error that says: "It's your first login! You need to reset your password." Click > on the reset password link below this message. >10) You should be sent to a page where you can reset your password. Fill in the > form and click 'Update password'. Attempt to sign into the OPAC with this new > password. Everything works as expected. >11) Go back to the staff interface and view this patron's detail page. Notice the > password expiration date is now set to what the default is in the patron > category. >12) Edit this patrons information and set their password expiration date to > yesterday. Go back to the OPAC and try to sign in with this patron again. Note > that this time, you are also redirected but the message says "Error: Your > password has expired!" >13) Go back to the staff interface and visit the sys. pref tab we left open. Set > it to the 'Force' option and save changes. >14) Visit the patron home page and click add patron, now select the patron > category again. Fill in required info and enter password. Submit form and note > that the patron's password expiration date is set to today. Try to login to > the OPAC with this patron, you should be redirected to the page with the error > that says "Error: It's your first login! You need to reset your password." >15) Sign-off :) > >Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Signed-off-by: Olivier V <olivier.vezina@inLibro.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Auth.pm | 2 ++ > Koha/Patron.pm | 15 +++++--- > Koha/Patron/Category.pm | 16 +++++++++ > admin/categories.pl | 4 +++ > .../prog/en/modules/admin/categories.tt | 35 +++++++++++++++++++ > .../en/modules/admin/preferences/patrons.pref | 2 +- > .../bootstrap/en/modules/opac-auth.tt | 12 +++++-- > 7 files changed, 77 insertions(+), 9 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index d4b83bb75ea..75b699456e6 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1457,6 +1457,8 @@ sub checkauth { > too_many_login_attempts => ( $patron and $patron->account_locked ), > password_has_expired => ( $patron and $patron->password_expired ), > is_anonymous_patron => ( $is_anonymous_patron ), >+ password_expiration_date => ( $patron and $patron->password_expiration_date ), >+ date_enrolled => ( $patron and $patron->dateenrolled ), > auth_error => $auth_error, > ); > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index fcbd6cd71ed..02ff8d4f7e9 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -291,11 +291,16 @@ sub store { > # Make a copy of the plain text password for later use > $self->plain_text_password( $self->password ); > >- $self->password_expiration_date( >- $self->password >- ? $self->category->get_password_expiry_date || undef >- : undef >- ); >+ if($self->category->effective_force_password_reset_when_set_by_staff and ($self->categorycode ne C4::Context->preference("PatronSelfRegistrationDefaultCategory"))){ >+ $self->password_expiration_date(dt_from_string); >+ } >+ else { >+ $self->password_expiration_date( >+ $self->password >+ ? $self->category->get_password_expiry_date || undef >+ : undef >+ ); >+ } > > # Create a disabled account if no password provided > $self->password( >diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm >index 70ebc007051..179397cb05d 100644 >--- a/Koha/Patron/Category.pm >+++ b/Koha/Patron/Category.pm >@@ -229,6 +229,22 @@ sub effective_require_strong_password { > return $self->require_strong_password // C4::Context->preference('RequireStrongPassword'); > } > >+=head3 effective_force_password_reset_when_set_by_staff >+ >+ $category->effective_force_password_reset_when_set_by_staff() >+ >+Returns if new staff created patrons in this category are forced to reset their password. If set in $self->force_password_reset_when_set_by_staff >+or, if undef, falls back to the ForcePasswordResetWhenSetByStaff system preference. >+ >+=cut >+ >+sub effective_force_password_reset_when_set_by_staff { >+ my ($self) = @_; >+ >+ return $self->force_password_reset_when_set_by_staff // C4::Context->preference('ForcePasswordResetWhenSetByStaff'); >+} >+ >+ > =head3 override_hidden_items > > if ( $patron->category->override_hidden_items ) { >diff --git a/admin/categories.pl b/admin/categories.pl >index 8fdaaf9d766..60d14a76b0f 100755 >--- a/admin/categories.pl >+++ b/admin/categories.pl >@@ -84,11 +84,13 @@ elsif ( $op eq 'cud-add_validate' ) { > > my @branches = grep { $_ ne q{} } $input->multi_param('branches'); > my $can_be_guarantee = $input->param('can_be_guarantee'); >+ my $force_password_reset_when_set_by_staff = $input->param('force_password_reset_when_set_by_staff'); > > $reset_password = undef if $reset_password eq -1; > $change_password = undef if $change_password eq -1; > $min_password_length = undef unless length($min_password_length); > $require_strong_password = undef if $require_strong_password eq -1; >+ $force_password_reset_when_set_by_staff = undef if $force_password_reset_when_set_by_staff eq -1; > > my $is_a_modif = $input->param("is_a_modif"); > >@@ -119,6 +121,7 @@ elsif ( $op eq 'cud-add_validate' ) { > $category->noissuescharge($noissuescharge); > $category->noissueschargeguarantees($noissueschargeguarantees); > $category->noissueschargeguarantorswithguarantees($noissueschargeguarantorswithguarantees); >+ $category->force_password_reset_when_set_by_staff($force_password_reset_when_set_by_staff); > eval { > $category->store; > $category->replace_library_limits( \@branches ); >@@ -157,6 +160,7 @@ elsif ( $op eq 'cud-add_validate' ) { > noissuescharge => $noissuescharge, > noissueschargeguarantees => $noissueschargeguarantees, > noissueschargeguarantorswithguarantees => $noissueschargeguarantorswithguarantees, >+ force_password_reset_when_set_by_staff => $force_password_reset_when_set_by_staff, > } > ); > eval { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index 16d8c875420..440da9eadeb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -341,6 +341,41 @@ > [% END %] > </select> > </li> >+ <li> >+ <label for="force_password_reset_when_set_by_staff">Force new patron password reset: </label> >+ <select name="force_password_reset_when_set_by_staff" id="force_password_reset_when_set_by_staff"> >+ [% IF category.force_password_reset_when_set_by_staff.defined %] >+ [% IF category.force_password_reset_when_set_by_staff %] >+ [% IF Koha.Preference('ForcePasswordResetWhenSetByStaff') %] >+ <option value="-1">Follow system preference ForcePasswordResetWhenSetByStaff (Force)</option> >+ [% ELSE %] >+ <option value="-1">Follow system preference ForcePasswordResetWhenSetByStaff (Don't force)</option> >+ [% END %] >+ <option value="1" selected="selected">Force</option> >+ <option value="0">Don't force</option> >+ [% ELSE %] >+ [% IF Koha.Preference('ForcePasswordResetWhenSetByStaff') %] >+ <option value="-1">Follow system preference ForcePasswordResetWhenSetByStaff (Force)</option> >+ [% ELSE %] >+ <option value="-1">Follow system preference ForcePasswordResetWhenSetByStaff (Don't force)</option> >+ [% END %] >+ <option value="1">Force</option> >+ <option value="0" selected="selected">Don't force</option> >+ [% END %] >+ [% ELSE %] >+ [% IF Koha.Preference('ForcePasswordResetWhenSetByStaff') %] >+ <option value="-1" selected="selected">Follow system preference ForcePasswordResetWhenSetByStaff (Force)</option> >+ [% ELSE %] >+ <option value="-1" selected="selected">Follow system preference ForcePasswordResetWhenSetByStaff (Don't force)</option> >+ [% END %] >+ <option value="1">Force</option> >+ <option value="0">Don't force</option> >+ [% END %] >+ </select> >+ <div class="hint"> >+ Choose whether staff created patrons of this category be forced into resetting their password after their first OPAC login. >+ </div> >+ </li> > <li><label for="block_expired">Block expired patron OPAC actions:</label> > <select name="BlockExpiredPatronOpacActions" id="block_expired" multiple="multiple"> > <optgroup label="Follow system preference"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >index fd1f146e59d..c5ed026abe0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >@@ -1,4 +1,4 @@ >-fPatrons: >+Patrons: > General: > - > - pref: CheckPrevCheckout >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index 632dab59cd9..bd87cc3cb03 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -202,9 +202,15 @@ > [% END %] > > [% IF !(invalid_username_or_password || too_many_login_attempts) and password_has_expired %] >- <div class="alert alert-info"> >- <p><strong>Error: </strong>Your password has expired!</p> >- </div> >+ [% IF date_enrolled == password_expiration_date %] >+ <div class="alert alert-info"> >+ <p><strong>Error: </strong>It's your first login! You need to reset your password.</p> >+ </div> >+ [% ELSE %] >+ <div class="alert alert-info"> >+ <p><strong>Error: </strong>Your password has expired!</p> >+ </div> >+ [% END %] > [% IF Koha.Preference('EnableExpiredPasswordReset') %] > <a href="/cgi-bin/koha/opac-reset-password.pl">Reset your password</a>. > [% ELSIF Koha.Preference('OpacPasswordChange') && Categories.can_any_reset_password %] >-- >2.39.5 (Apple Git-154)
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=172066">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33462
:
153687
|
153688
|
153689
|
154395
|
154396
|
154397
|
167582
|
167583
|
167584
|
167585
|
167586
|
167587
|
167981
|
167982
|
167983
|
167984
|
167985
|
167986
|
168413
|
168414
|
168415
|
168416
|
168417
|
168418
|
168452
|
168453
|
168454
|
168455
|
168456
|
168457
|
171634
|
171635
|
171636
|
171637
|
171638
|
171639
|
171640
|
172030
|
172031
|
172032
|
172033
|
172034
|
172035
|
172036
|
172064
|
172065
| 172066 |
172067
|
172068
|
172069
|
172070
|
172071
|
173864
|
173865