Attachment 172089 Details for Bug 33339 – Bug 33339: (Follow up) Fix more cases of formula=empty

[patch] Bug 33339: (Follow up) Fix more cases of formula=empty

Bug-33339-Follow-up-Fix-more-cases-of-formulaempty.patch (text/plain), 1.21 KB, created by Marcel de Rooy on 2024-09-27 07:37:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-09-27 07:37:10 UTC

Size: 1.21 KB

patch

obsolete

>From a893ade6f45ac3a4ae93d7bbd55135fda4a35297 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Fri, 16 Aug 2024 14:59:20 +0200
>Subject: [PATCH] Bug 33339: (Follow up) Fix more cases of formula=empty
>Content-Type: text/plain; charset=utf-8
>
>This patch adds formula=empty to:
>- Koha::ERM::EUsage::SushiCounter::_build_COUNTER_report_file()
>
>Updated 2024-09-26: Earlier version also removed unnecessary
>use of formula=empty from two places.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/ERM/EUsage/SushiCounter.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/ERM/EUsage/SushiCounter.pm b/Koha/ERM/EUsage/SushiCounter.pm
>index 4e33f8988f..10bde4ea21 100644
>--- a/Koha/ERM/EUsage/SushiCounter.pm
>+++ b/Koha/ERM/EUsage/SushiCounter.pm
>@@ -86,7 +86,7 @@ sub _build_COUNTER_report_file {
>     my @report = ( @{$header}, @{$column_headings}, @{$body} );
> 
>     #TODO: change this to tab instead of comma
>-    csv( in => \@report, out => \my $counter_file, encoding => "utf-8" );
>+    csv( in => \@report, out => \my $counter_file, encoding => "utf-8", formula => 'empty' );
> 
>     return $counter_file;
> 
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 33339: 148717 | 153997 | 170719 | 170720 | 171810 | 171811 | 171819 | 171820 | 171961 | 172088 | 172089