Attachment 172102 Details for Bug 36054 – Bug 36054: Don't mark MARC21 005 as mandatory in frameworks now that AddBiblio and ModBibilio will set it no matter what

[patch] Bug 36054: Don't mark MARC21 005 as mandatory in frameworks now that AddBiblio and ModBibilio will set it no matter what

Bug-36054-Dont-mark-MARC21-005-as-mandatory-in-fra.patch (text/plain), 2.44 KB, created by Marcel de Rooy on 2024-09-27 09:34:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-09-27 09:34:22 UTC

Size: 2.44 KB

patch

obsolete

>From ba01c1432f816a80f5719c08b486426f5606934b Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Fri, 7 Jun 2024 13:03:16 -0700
>Subject: [PATCH] Bug 36054: Don't mark MARC21 005 as mandatory in frameworks
> now that AddBiblio and ModBibilio will set it no matter what
>Content-Type: text/plain; charset=utf-8
>
>With bug 35993, both AddBiblio and ModBiblio will add a missing 005 or update
>an existing 005 to the current timestamp. That makes setting it as mandatory in
>bib frameworks pointless: whether you remove it, blank it, or set it, what you
>do doesn't matter because it will be set, and set to something different than
>what you set.
>
>Test plan:
>1. Apply patch, reset_all
>2. Administration - MARC bibliographic framework
>3. In the Default framework row, Actions - MARC structure
>4. In the 005 row, verify the Mandatory column says No
>5. 005 row, Actions - View subfields
>6. For the @ subfield, verify constraints says Not mandatory
>
>Extra credit: Set EnableAdvancedCatalogingEditor to Enable and in both editors
>try to save a record without a 005 or with one set to your choice of value, and
>then in the MARC preview verify that no matter what there is always a 005 with
>a value other than yours. Bonus for exporting a record, editing it with an
>external editor to remove the 005, reimporting it, and verifying that the
>imported record has a 005.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml b/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
>index 3eee078039..48fdce3942 100644
>--- a/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
>+++ b/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
>@@ -1026,7 +1026,7 @@ tables:
>           liblibrarian: "DATE AND TIME OF LATEST TRANSACTION"
>           libopac: "DATE AND TIME OF LATEST TRANSACTION"
>           repeatable: 0
>-          mandatory: 1
>+          mandatory: 0
>           authorised_value: ""
>           frameworkcode: ""
> 
>@@ -3885,7 +3885,7 @@ tables:
>           liblibrarian: "control field"
>           libopac: "control field"
>           repeatable: 0
>-          mandatory: 1
>+          mandatory: 0
>           kohafield: ""
>           tab: 0
>           authorised_value: ""
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 36054: 167588 | 172102 | 172115