Attachment 172168 Details for Bug 31391 – Bug 31391: Implement RecallsInterface on OPAC

[patch] Bug 31391: Implement RecallsInterface on OPAC

Bug-31391-Implement-RecallsInterface-on-OPAC.patch (text/plain), 4.88 KB, created by Aleisha Amohia on 2024-09-27 20:09:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2024-09-27 20:09:57 UTC

Size: 4.88 KB

patch

obsolete

>From 71514659dea24d2fff375623a84eb8bee7cd7e49 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Mon, 4 Oct 2021 17:23:06 +1300
>Subject: [PATCH] Bug 31391: Implement RecallsInterface on OPAC
>
>Signed-off-by: David <david@davidnind.com>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc     | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt        | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt        | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt           | 2 +-
> opac/opac-recall.pl                                             | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>index 211f6d6169c..8cb9a0f51d4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>@@ -9,7 +9,7 @@
>         [% END %]
>     [% END %]
> 
>-    [% IF Koha.Preference('UseRecalls') %]
>+    [% IF Koha.Preference('UseRecalls') AND Koha.Preference('RecallsInterface') != 'staff' %]
>         <li><a class="recall btn btn-link btn-lg" href="/cgi-bin/koha/opac-recall.pl?biblionumber=[% biblio.biblionumber | html %]"><i class="fa fa-solid fa-fw fa-book-bookmark" aria-hidden="true"></i>
>         Place recall</a></li>
>     [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index a8179b0e7a2..fcaf00e51c0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -11,7 +11,7 @@
> [% SET CartEnabled = ( Koha.Preference('opacbookbag') == 1 ) %]
> [% SET ListsEnabled = ( Koha.Preference('virtualshelves') == 1 ) && LoginEnabled %]
> [% SET HoldsEnabled = ( Koha.Preference('OPACHoldRequests') == 1 ) && LoginEnabled %]
>-[% SET RecallsEnabled = ( Koha.Preference('UseRecalls') == 1 ) && LoginEnabled %]
>+[% SET RecallsEnabled = ( Koha.Preference('UseRecalls') == 1 ) && LoginEnabled && ( Koha.Preference('RecallsInterface') != 'staff' ) %]
> [% SET ArticleRequestsEnabled = ( Koha.Preference('ArticleRequests') == 1 ) && LoginEnabled %]
> [% SET MultiHolds = ( Koha.Preference('DisplayMultiPlaceHold') == 1 ) && HoldsEnabled %]
> [% SET CoverImagePlugins = KohaPlugins.get_plugins_opac_cover_images %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 9c85e423c8a..a9df061992b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -13,7 +13,7 @@
> [% SET CartEnabled = ( Koha.Preference('opacbookbag') == 1 ) %]
> [% SET ListsEnabled = ( Koha.Preference('virtualshelves') == 1 ) && LoginEnabled %]
> [% SET HoldsEnabled = ( Koha.Preference('OPACHoldRequests') == 1 ) && LoginEnabled %]
>-[% SET RecallsEnabled = ( Koha.Preference('UseRecalls') == 1 ) && LoginEnabled %]
>+[% SET RecallsEnabled = ( Koha.Preference('UseRecalls') == 1 ) && LoginEnabled && ( Koha.Preference('RecallsInterface') != 'staff' ) %]
> [% SET ArticleRequestsEnabled = ( Koha.Preference('ArticleRequests') == 1 ) && LoginEnabled %]
> [% SET MultiHolds = ( Koha.Preference('DisplayMultiPlaceHold') == 1 ) && HoldsEnabled %]
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
>index a04c3ef29a7..bd0923d33eb 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
>@@ -12,7 +12,7 @@
> [% SET CartEnabled = ( Koha.Preference('opacbookbag') == 1 ) %]
> [% SET ListsEnabled = ( Koha.Preference('virtualshelves') == 1 ) && LoginEnabled %]
> [% SET HoldsEnabled = ( Koha.Preference('OPACHoldRequests') == 1 ) && LoginEnabled %]
>-[% SET RecallsEnabled = ( Koha.Preference('UseRecalls') == 1 ) && LoginEnabled %]
>+[% SET RecallsEnabled = ( Koha.Preference('UseRecalls') == 1 ) && LoginEnabled && ( Koha.Preference('RecallsInterface') != 'staff' ) %]
> [% SET ArticleRequestsEnabled = ( Koha.Preference('ArticleRequests') == 1 ) && LoginEnabled %]
> [% SET MultiHolds = ( Koha.Preference('DisplayMultiPlaceHold') == 1 ) && HoldsEnabled %]
> [% INCLUDE 'doc-head-open.inc' %]
>diff --git a/opac/opac-recall.pl b/opac/opac-recall.pl
>index eed014cbf5f..4f0b675e5da 100755
>--- a/opac/opac-recall.pl
>+++ b/opac/opac-recall.pl
>@@ -36,7 +36,7 @@ my $op = $query->param('op') || '';
> my $biblionumber = $query->param('biblionumber');
> my $biblio = Koha::Biblios->find( $biblionumber );
> 
>-if ( C4::Context->preference('UseRecalls') ) {
>+if ( C4::Context->preference('UseRecalls') and C4::Context->preference('RecallsInterface') ne 'staff' ) {
> 
>     my $patron = Koha::Patrons->find( $borrowernumber );
>     my $error;
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 31391: 139442 | 139443 | 139444 | 139446 | 139642 | 139643 | 139644 | 139645 | 141474 | 142594 | 143155 | 144104 | 144105 | 144131 | 144132 | 144133 | 144134 | 144135 | 144136 | 147581 | 147582 | 150485 | 150486 | 150487 | 150488 | 150489 | 150490 | 150491 | 156995 | 156996 | 156997 | 156998 | 156999 | 157000 | 157001 | 158691 | 158692 | 158693 | 158694 | 158695 | 158825 | 158826 | 158827 | 158828 | 158829 | 158830 | 158831 | 158832 | 172166 | 172167 | 172168 | 172169 | 172170 | 172171 | 172172 | 172173 | 172174 | 172175 | 173839 | 173840 | 173841 | 173842 | 173843 | 173844 | 173845 | 173846 | 173847 | 174396 | 174822 | 174823 | 174824 | 174825 | 174826 | 174827 | 174828 | 174829 | 174830 | 174831