Attachment 172184 Details for Bug 38016 – Bug 38016: Rename booking circulation rules

[patch] Bug 38016: Rename booking circulation rules

Bug-38016-Rename-booking-circulation-rules.patch (text/plain), 2.72 KB, created by Kyle M Hall (khall) on 2024-09-27 20:58:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-09-27 20:58:02 UTC

Size: 2.72 KB

patch

obsolete

>From 6d9a206797a4eb9fee38728d0d37974c7a9994a0 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleisha@catalyst.net.nz>
>Date: Fri, 27 Sep 2024 14:57:48 +0000
>Subject: [PATCH] Bug 38016: Rename booking circulation rules
>
>This enhancement renames the bookings circulation rules to better describe what they do.
>
>To test:
>
>1. Go to Koha Administration -> Circulation and fines rules
>2. Scroll to the 'Default holds and bookings policies by item type' section
>3. Notice the bookings rules in this table:
>  - Booking preparation period
>  - Booking precaution period
>4. Apply the patch and refresh the page
>5. Confirm the bookings have been renamed to:
>  - Booking pre-processing (days)
>  - Booking post-processing (days)
>6. Confirm these names make sense and it is clear what the rules are used for and how they are applied
>7. Put values in the input fields for these rules and confirm saving a rule works as expected
>
>Sponsored-by: Catalyst IT
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt    | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 370bd7b17ad..0b143b0cea4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -633,8 +633,8 @@
>                                 <th>Maximum total holds allowed (count)</th>
>                                 <th>Hold policy</th>
>                                 <th>Hold pickup library match</th>
>-                                <th>Booking preparation period</th>
>-                                <th>Booking precaution period</th>
>+                                <th>Booking pre-processing (days)</th>
>+                                <th>Booking post-processing (days)</th>
>                                 <th>Return policy</th>
>                                 <th class="noExport">Actions</th>
>                             </tr>
>@@ -1317,8 +1317,8 @@
>                                 <th>Item type</th>
>                                 <th>Hold policy</th>
>                                 <th>Hold pickup library match</th>
>-                                <th>Booking preparation period</th>
>-                                <th>Booking precaution period</th>
>+                                <th>Booking pre-processing (days)</th>
>+                                <th>Booking post-processing (days)</th>
>                                 <th>Return policy</th>
>                                 <th>&nbsp;</th>
>                             </tr>
>-- 
>2.39.5 (Apple Git-154)

Actions: View | Diff | Splinter Review

Attachments on bug 38016: 172119 | 172182 | 172184