Bugzilla – Attachment 172219 Details for
Bug 35570
Add a generic master form in ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35570: (QA follow-up): Standard backend: Biblio creation: Add UNIMARC support
Bug-35570-QA-follow-up-Standard-backend-Biblio-cre.patch (text/plain), 2.44 KB, created by
Pedro Amorim
on 2024-09-30 10:14:34 UTC
(
hide
)
Description:
Bug 35570: (QA follow-up): Standard backend: Biblio creation: Add UNIMARC support
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-09-30 10:14:34 UTC
Size:
2.44 KB
patch
obsolete
>From d0f96406f2455e7daead17ae32a2f1bfb2acb320 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 30 Sep 2024 10:08:44 +0000 >Subject: [PATCH] Bug 35570: (QA follow-up): Standard backend: Biblio creation: > Add UNIMARC support > >Add FreeForm UNIMARC enhancement from https://github.com/PTFS-Europe/koha-ill-freeform/commit/5d07c68f8058a9a1f35e3193699605240741ff0c into this work. >This is to keep this work up to date with latest FreeForm's work. > >To test, k-t-d: >1) (Skip if using sandboxes) Start off by ensuring this is a UNIMARC installation, run: >$ reset_all_unimarc >2) (Skip if using sandboxes) Apply this bug 35570 >3) Create a new Standard ILL request: ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm >4) Select type: book, input different values for title+author+isbn (the remaining fields are optional > for this test) >5) Put in a cardnumber ('42' is kohaadmin if k-t-d/sandboxes). Select any library. > Click 'Create'. >6) You should now see the ILL request details page. Click on the > 'Bibliographic record ID' link. >7) Ensure the newly created biblio record has the title+author+isbn from > the metadata originally submitted. > >Raised by Sonia Bouis at KohaCon's 2024 ILL workshop >--- > Koha/ILL/Backend/Standard.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 95c4eec858b..5aba0eab1fa 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -1166,15 +1166,15 @@ sub _standard_request2biblio { > } > > if ($isbn) { >- my $marc_isbn = MARC::Field->new( '020', '', '', a => $isbn ); >+ my $marc_isbn = $marcflavour eq 'MARC21' ? MARC::Field->new( '020', '', '', a => $isbn ) : MARC::Field->new( '010', '', '', a => $isbn ); > $record->append_fields($marc_isbn); > } > if ($author) { >- my $marc_author = MARC::Field->new( '100', '1', '', a => $author ); >+ my $marc_author = $marcflavour eq 'MARC21' ? MARC::Field->new( '100', '1', '', a => $author ) : MARC::Field->new( '700', '1', '', a => $author ); > $record->append_fields($marc_author); > } > if ($title) { >- my $marc_title = MARC::Field->new( '245', '0', '0', a => $title ); >+ my $marc_title = $marcflavour eq 'MARC21' ? MARC::Field->new( '245', '0', '0', a => $title ) : MARC::Field->new( '200', '0', '0', a => $title ); > $record->append_fields($marc_title); > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35570
:
159942
|
159943
|
159944
|
159946
|
159947
|
160452
|
160457
|
160654
|
160655
|
160656
|
160657
|
160658
|
160659
|
160660
|
160686
|
161519
|
161520
|
161521
|
161522
|
161523
|
161524
|
162894
|
162897
|
162898
|
162899
|
162900
|
162901
|
162902
|
162903
|
162904
|
162905
|
164277
|
164278
|
164279
|
164280
|
164281
|
164282
|
164283
|
164284
|
165204
|
165205
|
165206
|
165207
|
165208
|
165209
|
165210
|
165211
|
165286
|
165287
|
165288
|
165289
|
165290
|
165291
|
165292
|
165293
|
167050
|
167051
|
171312
|
171313
|
171314
|
171315
|
171316
|
171317
|
171318
|
171319
|
171320
|
171321
|
171322
|
171323
|
172218
|
172219
|
172722
|
172723
|
172724
|
172725
|
172726
|
172727
|
172728
|
172729
|
172730
|
172731
|
172732
|
172733
|
172734
|
172735
|
172740
|
172741
|
172742
|
172743
|
172744
|
172745
|
172746
|
172747
|
172748
|
172749
|
172750
|
172751
|
172752
|
172753
|
172780
|
172809
|
172811
|
173916
|
173917
|
173918