Attachment 172257 Details for Bug 28575 – Bug 28575: (QA follow-up) Tidy and test count

[patch] Bug 28575: (QA follow-up) Tidy and test count

Bug-28575-QA-follow-up-Tidy-and-test-count.patch (text/plain), 2.94 KB, created by Nick Clemens (kidclamp) on 2024-10-01 11:08:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-10-01 11:08:56 UTC

Size: 2.94 KB

patch

obsolete

>From 1f2564f8d5a9648224939c95d899dfb913c3bbf7 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 1 Oct 2024 10:57:25 +0000
>Subject: [PATCH] Bug 28575: (QA follow-up) Tidy and test count
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Circulation.pm            | 8 ++++----
> circ/returns.pl              | 5 +----
> t/db_dependent/Circulation.t | 6 +++---
> 3 files changed, 8 insertions(+), 11 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 9fef2c0a327..49dfa60b94e 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2313,13 +2313,13 @@ sub AddReturn {
>             my @object_messages = @{ $updated_item->object_messages };
>             for my $message (@object_messages) {
>                 $messages->{'LostItemFeeRefunded'} = 1
>-                  if $message->message eq 'lost_refunded';
>+                    if $message->message eq 'lost_refunded';
>                 $messages->{'ProcessingFeeRefunded'} = 1
>-                  if $message->message eq 'processing_refunded';
>+                    if $message->message eq 'processing_refunded';
>                 $messages->{'LostItemFeeRestored'} = 1
>-                  if $message->message eq 'lost_restored';
>+                    if $message->message eq 'lost_restored';
>                 $messages->{'LostItemPaymentNotRefunded'} = 1
>-                  if $message->message eq 'payment_not_refunded';
>+                    if $message->message eq 'payment_not_refunded';
> 
>                 if ( $message->message eq 'lost_charge' ) {
>                     $issue //= Koha::Old::Checkouts->search(
>diff --git a/circ/returns.pl b/circ/returns.pl
>index e41cf9ab269..ea80408684b 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -703,10 +703,7 @@ foreach my $code ( keys %$messages ) {
>     elsif ( $code eq 'LostItemFeeRefunded' ) {
>         $template->param( LostItemFeeRefunded => 1 );
>     }
>-    elsif (
>-        $code eq 'LostItemPaymentNotRefunded'
>-        )
>-    {
>+    elsif ( $code eq 'LostItemPaymentNotRefunded' ) {
>         $template->param( LostItemPaymentNotRefunded => 1 );
>     }
>     elsif ( $code eq 'LostItemFeeCharged' ) {
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 0921dfb6448..ef187d0581c 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -18,7 +18,7 @@
> use Modern::Perl;
> use utf8;
> 
>-use Test::More tests => 75;
>+use Test::More tests => 76;
> use Test::Exception;
> use Test::MockModule;
> use Test::Deep qw( cmp_deeply );
>@@ -6868,8 +6868,8 @@ subtest 'NoRefundOnLostFinesPaidAge' => sub {
>             date              => '1970-01-01 14:00:01',
>             amountoutstanding => 0,
>             amount            => -5,
>-            interface        => 'commandline',
>-            credit_type_code => 'PAYMENT'
>+            interface         => 'commandline',
>+            credit_type_code  => 'PAYMENT'
>         }
>     )->store();
>     my $offset = Koha::Account::Offset->new(
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 28575: 167567 | 167568 | 167569 | 167621 | 167622 | 167623 | 167624 | 167627 | 167635 | 167636 | 167637 | 167638 | 168146 | 172252 | 172253 | 172254 | 172255 | 172256 | 172257 | 172258