Attachment 172273 Details for Bug 37810 – Bug 37810: Consider ServiceActive on status response

[patch] Bug 37810: Consider ServiceActive on status response

Bug-37810-Consider-ServiceActive-on-status-respons.patch (text/plain), 1.29 KB, created by Nick Clemens (kidclamp) on 2024-10-01 14:07:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-10-01 14:07:19 UTC

Size: 1.29 KB

patch

obsolete

>From 5ef2d7349f7a927e84cafd83fbb4740482989d45 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 2 Sep 2024 14:51:31 +0000
>Subject: [PATCH] Bug 37810: Consider ServiceActive on status response
>
>Some SUSHI providers return ServiceActive instead of the documented Service_Active:
>https://countermetrics.stoplight.io/docs/counter-sushi-api/f0dd30f814944-server-status
>
>This ensures the test connection does not fail regardless of what is used
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/ERM/EUsage/UsageDataProvider.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/ERM/EUsage/UsageDataProvider.pm b/Koha/ERM/EUsage/UsageDataProvider.pm
>index d70755ae5c2..cdb82e31d5f 100644
>--- a/Koha/ERM/EUsage/UsageDataProvider.pm
>+++ b/Koha/ERM/EUsage/UsageDataProvider.pm
>@@ -294,10 +294,10 @@ sub test_connection {
>     my $status;
>     if ( ref($result) eq 'ARRAY' ) {
>         for my $r (@$result) {
>-            $status = $r->{Service_Active};
>+            $status = $r->{Service_Active} // $r->{ServiceActive};
>         }
>     } else {
>-        $status = $result->{Service_Active};
>+        $status = $result->{Service_Active} // $result->{ServiceActive};
>     }
> 
>     if ($status) {
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37810: 170947 | 171717 | 171718 | 172198 | 172199 | 172272 | 172273 | 172274