Attachment 172274 Details for Bug 37810 – Bug 37810: (QA follow-up) Tidy

[patch] Bug 37810: (QA follow-up) Tidy

Bug-37810-QA-follow-up-Tidy.patch (text/plain), 2.56 KB, created by Nick Clemens (kidclamp) on 2024-10-01 14:07:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-10-01 14:07:21 UTC

Size: 2.56 KB

patch

obsolete

>From b40e5d13baf3bce0014ed5c9c50320541206d0e9 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 1 Oct 2024 14:05:56 +0000
>Subject: [PATCH] Bug 37810: (QA follow-up) Tidy
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../Koha/ERM/EUsage/UsageDataProvider.t       | 46 +++++++++++++------
> 1 file changed, 31 insertions(+), 15 deletions(-)
>
>diff --git a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t
>index 3f64e0e1d3f..941bfe351d3 100755
>--- a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t
>+++ b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t
>@@ -118,29 +118,45 @@ subtest 'test_connection() tests' => sub {
>     $schema->storage->txn_begin;
> 
>     my $ua = Test::MockModule->new('LWP::UserAgent');
>-    $ua->mock('simple_request', sub {
>+    $ua->mock(
>+        'simple_request',
>+        sub {
>             my $response = Test::MockObject->new();
> 
>-            $response->mock('code', sub {
>-                return 200;
>-            });
>-            $response->mock('is_error', sub {
>-                return 0;
>-            });
>-            $response->mock('is_redirect', sub {
>-                return 0;
>-            });
>-            $response->mock('decoded_content', sub {
>-                return '{"Description":"COUNTER Usage Reports for Test platform.","ServiceActive":true,"RegistryURL":"https://www.whatever.com"}';
>-            });
>+            $response->mock(
>+                'code',
>+                sub {
>+                    return 200;
>+                }
>+            );
>+            $response->mock(
>+                'is_error',
>+                sub {
>+                    return 0;
>+                }
>+            );
>+            $response->mock(
>+                'is_redirect',
>+                sub {
>+                    return 0;
>+                }
>+            );
>+            $response->mock(
>+                'decoded_content',
>+                sub {
>+                    return
>+                        '{"Description":"COUNTER Usage Reports for Test platform.","ServiceActive":true,"RegistryURL":"https://www.whatever.com"}';
>+                }
>+            );
>             $response->{_rc} = 200;
>             return $response;
>-    });
>+        }
>+    );
> 
>     my $usage_data_provider = $builder->build_object(
>         { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { name => 'TestProvider' } } );
> 
>-    is( $usage_data_provider->test_connection, 1);
>+    is( $usage_data_provider->test_connection, 1 );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37810: 170947 | 171717 | 171718 | 172198 | 172199 | 172272 | 172273 | 172274